Ver Fonte

LibJS: Rename DurationFormat's DurationSign to DurationRecordSign

This is an editorial change in the Intl.DurationFormat proposal. See:
https://github.com/tc39/proposal-intl-duration-format/commit/f947239
Timothy Flynn há 2 anos atrás
pai
commit
a86b840c64

+ 4 - 4
Userland/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp

@@ -177,8 +177,8 @@ ThrowCompletionOr<Temporal::DurationRecord> to_duration_record(VM& vm, Value inp
     return result;
     return result;
 }
 }
 
 
-// 1.1.4 DurationSign ( record ), https://tc39.es/proposal-intl-duration-format/#sec-durationsign
-i8 duration_sign(Temporal::DurationRecord const& record)
+// 1.1.4 DurationRecordSign ( record ), https://tc39.es/proposal-intl-duration-format/#sec-durationrecordsign
+i8 duration_record_sign(Temporal::DurationRecord const& record)
 {
 {
     // 1. For each row in Table 1, except the header row, in table order, do
     // 1. For each row in Table 1, except the header row, in table order, do
     for (auto const& duration_instances_component : duration_instances_components) {
     for (auto const& duration_instances_component : duration_instances_components) {
@@ -204,8 +204,8 @@ i8 duration_sign(Temporal::DurationRecord const& record)
 // 1.1.5 IsValidDurationRecord ( record ), https://tc39.es/proposal-intl-duration-format/#sec-isvaliddurationrecord
 // 1.1.5 IsValidDurationRecord ( record ), https://tc39.es/proposal-intl-duration-format/#sec-isvaliddurationrecord
 bool is_valid_duration_record(Temporal::DurationRecord const& record)
 bool is_valid_duration_record(Temporal::DurationRecord const& record)
 {
 {
-    // 1. Let sign be ! DurationSign(record).
-    auto sign = duration_sign(record);
+    // 1. Let sign be ! DurationRecordSign(record).
+    auto sign = duration_record_sign(record);
 
 
     // 2. For each row in Table 1, except the header row, in table order, do
     // 2. For each row in Table 1, except the header row, in table order, do
     for (auto const& duration_instances_component : duration_instances_components) {
     for (auto const& duration_instances_component : duration_instances_components) {

+ 1 - 1
Userland/Libraries/LibJS/Runtime/Intl/DurationFormat.h

@@ -221,7 +221,7 @@ struct DurationUnitOptions {
 };
 };
 
 
 ThrowCompletionOr<Temporal::DurationRecord> to_duration_record(VM&, Value input);
 ThrowCompletionOr<Temporal::DurationRecord> to_duration_record(VM&, Value input);
-i8 duration_sign(Temporal::DurationRecord const&);
+i8 duration_record_sign(Temporal::DurationRecord const&);
 bool is_valid_duration_record(Temporal::DurationRecord const&);
 bool is_valid_duration_record(Temporal::DurationRecord const&);
 ThrowCompletionOr<DurationUnitOptions> get_duration_unit_options(VM&, String const& unit, Object const& options, StringView base_style, Span<StringView const> styles_list, StringView digital_base, StringView previous_style);
 ThrowCompletionOr<DurationUnitOptions> get_duration_unit_options(VM&, String const& unit, Object const& options, StringView base_style, Span<StringView const> styles_list, StringView digital_base, StringView previous_style);
 Vector<PatternPartition> partition_duration_format_pattern(VM&, DurationFormat const&, Temporal::DurationRecord const& duration);
 Vector<PatternPartition> partition_duration_format_pattern(VM&, DurationFormat const&, Temporal::DurationRecord const& duration);