0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Don't treat auto insets as definite for child of abspos element

Browse source 
This fixes an issue where the welcome screen wasn't showing up the first
time you visit https://puter.com/ :^)
This commit is contained in:
Andreas Kling 2024-11-27 19:15:04 +01:00 • committed by Andreas Kling
parent e43e4d3a93
commit a74954e145
Notes: github-actions[bot] 2024-11-27 21:56:05 +00:00
3 changed files with 25 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/Layout/FormattingContext.cpp
View file

@ -1226,10 +1226,15 @@ void FormattingContext::layout_absolutely_positioned_element(Box const& box, Ava
// If the box width and/or height is fixed and/or or resolved from inset properties,
// mark the size as being definite (since layout was not required to resolve it, per CSS-SIZING-3).
if (box.computed_values().inset().left().is_length() && box.computed_values().inset().right().is_length()) {
auto is_length_but_not_auto = [](auto& length_percentage) {
return length_percentage.is_length() && !length_percentage.is_auto();
};
if (is_length_but_not_auto(box.computed_values().inset().left())
&& is_length_but_not_auto(box.computed_values().inset().right())) {
box_state.set_has_definite_width(true);
}
if (box.computed_values().inset().top().is_length() && box.computed_values().inset().bottom().is_length()) {
if (is_length_but_not_auto(box.computed_values().inset().top())
&& is_length_but_not_auto(box.computed_values().inset().bottom())) {
box_state.set_has_definite_height(true);
}

13
Tests/LibWeb/Layout/expected/child-of-abspos-percentage-height.txt Normal file
View file

@ -0,0 +1,13 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x0 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 36.84375x17 positioned [BFC] children: not-inline
BlockContainer <div> at (8,8) content-size 36.84375x17 children: inline
frag 0 from TextNode start: 0, length: 5, rect: [8,8 36.84375x17] baseline: 13.296875
"hello"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x0]
PaintableWithLines (BlockContainer<BODY>) [8,8 36.84375x17]
PaintableWithLines (BlockContainer<DIV>) [8,8 36.84375x17]
TextPaintable (TextNode<#text>)

5
Tests/LibWeb/Layout/input/child-of-abspos-percentage-height.html Normal file
View file

@ -0,0 +1,5 @@
<!doctype html><style>
* { outline: 1px solid black; }
body { position: absolute; }
div { height: 100%; }
</style><body><div>hello