0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Implement basic support for window[number]

Browse source 
This fixes an assertion on https://amazon.com/ since WindowProxy
would advertise "0" as an own property key, but then act like it was
a bogus property when actually queried for it directly.
This commit is contained in:
Andreas Kling 2023-07-25 15:07:13 +02:00
parent c431167736
commit a653b60e49
Notes: sideshowbarker 2024-07-17 18:49:10 +09:00
3 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Text/expected/window-proxy-numeric-own-property.txt Normal file
View file

@ -0,0 +1,3 @@
true
[object Window]
false

9
Tests/LibWeb/Text/input/window-proxy-numeric-own-property.html Normal file
View file

@ -0,0 +1,9 @@
<script src="include.js"></script>
<iframe src="about:blank"></iframe>
<script>
test(() => {
println(0 in window)
println(window[0])
println(1 in window)
});
</script>

7
Userland/Libraries/LibWeb/HTML/WindowProxy.cpp
View file

@ -80,7 +80,12 @@ JS::ThrowCompletionOr<Optional<JS::PropertyDescriptor>> WindowProxy::internal_ge
// 4. If maxProperties is greater than 0 and index is less than maxProperties, then set value to the WindowProxy object of the indexth document-tree child browsing context of W's browsing context, sorted in the order that their browsing context container elements were most recently inserted into W's associated Document, the WindowProxy object of the most recently inserted browsing context container's nested browsing context being last.
if (max_properties > 0 && index < max_properties) {
// FIXME: Implement this.
JS::MarkedVector<BrowsingContext*> browsing_contexts { vm.heap() };
m_window->browsing_context()->for_each_child([&](BrowsingContext& child) {
if (child.container() && child.container()->in_a_document_tree())
browsing_contexts.append(&child);
});
value = JS::Value(browsing_contexts[index]->window_proxy());
}
// 5. If value is undefined, then: