Kaynağa Gözat

LibHTML: Ignore completed image loads for already-destroyed <img>'s

Capture a weak pointer to the element and pass that to the load finish
callback in HTMLImageElement::load_image(). This allows us to ignore
completed loads if the <img> element is no longer around.
Andreas Kling 5 yıl önce
ebeveyn
işleme
a5f3f332ed
1 değiştirilmiş dosya ile 5 ekleme ve 1 silme
  1. 5 1
      Libraries/LibHTML/DOM/HTMLImageElement.cpp

+ 5 - 1
Libraries/LibHTML/DOM/HTMLImageElement.cpp

@@ -23,7 +23,11 @@ void HTMLImageElement::parse_attribute(const String& name, const String& value)
 void HTMLImageElement::load_image(const String& src)
 void HTMLImageElement::load_image(const String& src)
 {
 {
     URL src_url = document().complete_url(src);
     URL src_url = document().complete_url(src);
-    ResourceLoader::the().load(src_url, [this](auto data) {
+    ResourceLoader::the().load(src_url, [this, weak_element = make_weak_ptr()](auto data) {
+        if (!weak_element) {
+            dbg() << "HTMLImageElement: Load completed after element destroyed.";
+            return;
+        }
         if (data.is_null()) {
         if (data.is_null()) {
             dbg() << "HTMLImageElement: Failed to load " << this->src();
             dbg() << "HTMLImageElement: Failed to load " << this->src();
             return;
             return;