0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel: Hold a weak reference to a Process object in AsyncDeviceRequest

Browse source 
The process could be long gone by the point the async IO request has
completed so hold a weak reference pointer to the requesting Process and
try get a strong reference only when needed.

This patch is necessary because otherwise async IO requests can hold
Process objects long after they were terminated, which would make it
impossible to perform certain tasks in the system, like killing all user
processes during the shutdown procedure.
This commit is contained in:
Liav A 2023-08-19 11:38:32 +03:00 • committed by Andrew Kaster
parent dbab4d34d7
commit a43133b3c7
Notes: sideshowbarker 2024-07-17 10:31:19 +09:00
1 changed files with 23 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
Kernel/Devices/AsyncDeviceRequest.h
View file

@ -84,36 +84,48 @@ public:
template<typename... Args>
ErrorOr<void> write_to_buffer(UserOrKernelBuffer& buffer, Args... args)
{
if (in_target_context(buffer))
auto process = m_process.strong_ref();
if (!process)
return Error::from_errno(ESRCH);
if (in_target_context(*process, buffer))
return buffer.write(forward<Args>(args)...);
ScopedAddressSpaceSwitcher switcher(m_process);
ScopedAddressSpaceSwitcher switcher(*process);
return buffer.write(forward<Args>(args)...);
}
template<size_t BUFFER_BYTES, typename... Args>
ErrorOr<size_t> write_to_buffer_buffered(UserOrKernelBuffer& buffer, Args... args)
{
if (in_target_context(buffer))
auto process = m_process.strong_ref();
if (!process)
return Error::from_errno(ESRCH);
if (in_target_context(*process, buffer))
return buffer.write_buffered<BUFFER_BYTES>(forward<Args>(args)...);
ScopedAddressSpaceSwitcher switcher(m_process);
ScopedAddressSpaceSwitcher switcher(*process);
return buffer.write_buffered<BUFFER_BYTES>(forward<Args>(args)...);
}
template<typename... Args>
ErrorOr<void> read_from_buffer(UserOrKernelBuffer const& buffer, Args... args)
{
if (in_target_context(buffer))
auto process = m_process.strong_ref();
if (!process)
return Error::from_errno(ESRCH);
if (in_target_context(*process, buffer))
return buffer.read(forward<Args>(args)...);
ScopedAddressSpaceSwitcher switcher(m_process);
ScopedAddressSpaceSwitcher switcher(*process);
return buffer.read(forward<Args>(args)...);
}
template<size_t BUFFER_BYTES, typename... Args>
ErrorOr<size_t> read_from_buffer_buffered(UserOrKernelBuffer const& buffer, Args... args)
{
if (in_target_context(buffer))
auto process = m_process.strong_ref();
if (!process)
return Error::from_errno(ESRCH);
if (in_target_context(*process, buffer))
return buffer.read_buffered<BUFFER_BYTES>(forward<Args>(args)...);
ScopedAddressSpaceSwitcher switcher(m_process);
ScopedAddressSpaceSwitcher switcher(*process);
return buffer.read_buffered<BUFFER_BYTES>(forward<Args>(args)...);
}
@ -126,11 +138,11 @@ private:
void sub_request_finished(AsyncDeviceRequest&);
void request_finished();
[[nodiscard]] bool in_target_context(UserOrKernelBuffer const& buffer) const
[[nodiscard]] bool in_target_context(Process& process, UserOrKernelBuffer const& buffer) const
{
if (buffer.is_kernel_buffer())
return true;
return m_process == &Process::current();
return &process == &Process::current();
}
[[nodiscard]] static bool is_completed_result(RequestResult result)
@ -149,7 +161,7 @@ private:
AsyncDeviceSubRequestList m_sub_requests_pending;
AsyncDeviceSubRequestList m_sub_requests_complete;
WaitQueue m_queue;
NonnullRefPtr<Process> const m_process;
LockWeakPtr<Process> const m_process;
void* m_private { nullptr };
mutable Spinlock<LockRank::None> m_lock {};
};