0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Avoid division by zero when calculating scrollbar rect

Browse source
This commit is contained in:
Tim Ledbetter 2024-03-17 07:15:29 +00:00 • committed by Andreas Kling
parent 0afbd827e0
commit a40c14462d
Notes: sideshowbarker 2024-07-17 10:31:19 +09:00
3 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/overflow-with-zero-sized-box.txt Normal file
View file

@ -0,0 +1 @@
PASS (didn't crash)

13
Tests/LibWeb/Text/input/overflow-with-zero-sized-box.html Normal file
View file

@ -0,0 +1,13 @@
<!DOCTYPE html>
<script src="include.js"></script>
<script>
test(() => {
const parent = document.createElement("div");
parent.style.width = 0;
parent.style.overflow = 'scroll'
const child = document.createElement("div");
child.style.width = 0;
document.body.appendChild(parent);
println("PASS (didn't crash)");
});
</script>

2
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -276,6 +276,8 @@ Optional<CSSPixelRect> PaintableBox::scroll_thumb_rect(ScrollDirection direction
auto scroll_overflow_size = direction == ScrollDirection::Horizontal ? scrollable_overflow_rect.width() : scrollable_overflow_rect.height();
auto scrollport_size = direction == ScrollDirection::Horizontal ? padding_rect.width() : padding_rect.height();
auto scroll_offset = direction == ScrollDirection::Horizontal ? this->scroll_offset().x() : this->scroll_offset().y();
if (scroll_overflow_size == 0)
return {};
auto thumb_size = scrollport_size * (scrollport_size / scroll_overflow_size);
CSSPixels thumb_position = 0;