소스 검색

LibWeb: Fix incompatibility of attribute "contenteditable"

The previous behavior of mapping a missing value to the "inherit"
state is incompatible. Now, a missing value maps to the "true" state,
which is the expected behavior.
SeekingBlues 4 년 전
부모
커밋
a13a5315a5
1개의 변경된 파일3개의 추가작업 그리고 3개의 파일을 삭제
  1. 3 3
      Userland/Libraries/LibWeb/HTML/HTMLElement.cpp

+ 3 - 3
Userland/Libraries/LibWeb/HTML/HTMLElement.cpp

@@ -33,13 +33,13 @@ HTMLElement::~HTMLElement()
 HTMLElement::ContentEditableState HTMLElement::content_editable_state() const
 {
     auto contenteditable = attribute(HTML::AttributeNames::contenteditable);
-    // "true" and the empty string map to the "true" state.
-    if ((!contenteditable.is_null() && contenteditable.is_empty()) || contenteditable.equals_ignoring_case("true"))
+    // "true", an empty string or a missing value map to the "true" state.
+    if (contenteditable.is_empty() || contenteditable.equals_ignoring_case("true"))
         return ContentEditableState::True;
     // "false" maps to the "false" state.
     if (contenteditable.equals_ignoring_case("false"))
         return ContentEditableState::False;
-    // "inherit", an invalid value, and a missing value all map to the "inherit" state.
+    // An invalid value maps to the "inherit" state.
     return ContentEditableState::Inherit;
 }