0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-11 17:00:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Piano: Remove waveform cycling with C

Browse source 
This is not the most useful keyboard binding anyways, plus it will be
extremely hacky to implement it with the generic processor parameter
widgets. Therefore, we'll get rid of it and add back a more generic
keyboard binding system later.
This commit is contained in:
kleines Filmröllchen 2022-07-23 15:44:16 +02:00 committed by Andreas Kling
parent 196841fd3a
commit a0b2e8608b
Notes: sideshowbarker 2024-07-17 08:35:44 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/a0b2e8608b
Pull-request: https://github.com/SerenityOS/serenity/pull/14664
3 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/Piano/KnobsWidget.cpp
View file

@ -104,11 +104,6 @@ KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget)
}
}
void KnobsWidget::cycle_waveform()
{
m_synth_waveform->set_selected_index((m_synth_waveform->selected_index() + 1) % m_synth_waveform->model()->row_count());
}
void KnobsWidget::update_knobs()
{
// FIXME: This is needed because when the slider is changed normally, we

1
Userland/Applications/Piano/KnobsWidget.h
View file

@ -26,7 +26,6 @@ public:
virtual ~KnobsWidget() override = default;
void update_knobs();
void cycle_waveform();
private:
KnobsWidget(TrackManager&, MainWidget&);

3
Userland/Applications/Piano/MainWidget.cpp
View file

@ -115,9 +115,6 @@ void MainWidget::special_key_action(int key_code)
case Key_X:
set_octave_and_ensure_note_change(DSP::Keyboard::Direction::Up);
break;
case Key_C:
m_knobs_widget->cycle_waveform();
break;
case Key_Space:
m_player_widget->toggle_paused();
break;