Prechádzať zdrojové kódy

LibJS: Add fast path for Array.length in the bytecode interpreter

13.8% speed-up on Kraken/ai-astar.js in interpreter mode. :^)
Andreas Kling 1 rok pred
rodič
commit
9fcd6776cf

+ 5 - 0
Userland/Libraries/LibJS/Bytecode/CommonImplementations.h

@@ -84,6 +84,11 @@ inline ThrowCompletionOr<Value> get_by_id(VM& vm, DeprecatedFlyString const& pro
 
     auto base_obj = TRY(base_object_for_get(vm, base_value));
 
+    // OPTIMIZATION: Fast path for the magical "length" property on Array objects.
+    if (base_obj->has_magical_length_property() && property == vm.names.length.as_string()) {
+        return Value { base_obj->indexed_properties().array_like_size() };
+    }
+
     // OPTIMIZATION: If the shape of the object hasn't changed, we can use the cached property offset.
     auto& shape = base_obj->shape();
     if (&shape == cache.shape) {