Bläddra i källkod

SharedGraphics: Font::load_from_file() forgot to close() the font file.

Andreas Kling 6 år sedan
förälder
incheckning
9da9cce4f7
1 ändrade filer med 7 tillägg och 1 borttagningar
  1. 7 1
      SharedGraphics/Font.cpp

+ 7 - 1
SharedGraphics/Font.cpp

@@ -154,12 +154,18 @@ RetainPtr<Font> Font::load_from_file(const String& path)
     }
 
     auto* mapped_file = (byte*)mmap(nullptr, 4096 * 3, PROT_READ, MAP_SHARED, fd, 0);
-    if (mapped_file == MAP_FAILED)
+    if (mapped_file == MAP_FAILED) {
+        int rc = close(fd);
+        ASSERT(rc == 0);
         return nullptr;
+    }
 
     auto font = load_from_memory(mapped_file);
     int rc = munmap(mapped_file, 4096 * 3);
     ASSERT(rc == 0);
+
+    rc = close(fd);
+    ASSERT(rc == 0);
     return font;
 }