0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions2

LibJS: Do not store console table columns and rows in a plain vector

Browse source 
These values may contain Object types.
This commit is contained in:
Timothy Flynn 2024-10-31 12:21:37 -04:00 • committed by Alexander Kalenik
parent cd2a34deb7
commit 9949173fce
Notes: github-actions[bot] 2024-10-31 23:37:04 +00:00
1 changed files with 3 additions and 3 deletions

6
Userland/Libraries/LibJS/Console.cpp
View file

@ -143,7 +143,7 @@ ThrowCompletionOr<Value> Console::log()
}
// To [create table row] given tabularDataItem, rowIndex, list finalColumns, and optional list properties, perform the following steps:
static ThrowCompletionOr<NonnullGCPtr<Object>> create_table_row(Realm& realm, Value row_index, Value tabular_data_item, Vector<Value>& final_columns, HashMap<PropertyKey, bool>& visited_columns, HashMap<PropertyKey, bool>& properties)
static ThrowCompletionOr<NonnullGCPtr<Object>> create_table_row(Realm& realm, Value row_index, Value tabular_data_item, MarkedVector<Value>& final_columns, HashMap<PropertyKey, bool>& visited_columns, HashMap<PropertyKey, bool>& properties)
{
auto& vm = realm.vm();
@ -265,10 +265,10 @@ ThrowCompletionOr<Value> Console::table()
}
// 1. Let `finalRows` be the new list, initially empty
Vector<Value> final_rows;
MarkedVector<Value> final_rows(vm.heap());
// 2. Let `finalColumns` be the new list, initially empty
Vector<Value> final_columns;
MarkedVector<Value> final_columns(vm.heap());
HashMap<PropertyKey, bool> visited_columns;