We use cookies to ensure you get the best experience on our website
首页 发现 帮助
注册 登录
0ct0pu5
/
ladybird
1
0
派生 0
文件 工单管理 0 合并请求 0 Wiki
浏览代码

LibWeb: Skip HTMLLinkElement resource fetching for documents without BC

Fixes crashing after following steps:
1. Open https://github.com/SerenityOS/serenity
2. Click on "Pull requests" tab

The problem was `navigable` null pointer dereferencing in
`decode_favicon()`. But navigable is null because the document was
created by `parseFromString()` DOMParser API.

With this change we skip fetching initiated by HTMLLinkElement if
document does not have a browsing context:
- Favicon is not displayed for such documents so no need to fetch.
- Stylesheets fetching won't affect such document because style or
  layout does not run for them.
Aliaksandr Kalenik 1 年之前
父节点
4c921e17b7
当前提交
988c8451d4
共有 4 个文件被更改，包括 16 次插入 和 1 次删除
合并视图 显示文件统计
  1. 1 1
      Tests/LibWeb/Text/expected/css/move-loaded-link-stylesheet-between-documents.txt
  2. 1 0
      Tests/LibWeb/Text/expected/favicon-in-inactive-document.txt
  3. 10 0
      Tests/LibWeb/Text/input/favicon-in-inactive-document.html
  4. 4 0
      Userland/Libraries/LibWeb/HTML/HTMLLinkElement.cpp

+ 1 - 1
Tests/LibWeb/Text/expected/css/move-loaded-link-stylesheet-between-documents.txt
查看文件 

@@ -1,3 +1,3 @@
 
 Sheets in old doc: 0
 
 Sheets in old doc: 0
 
-Sheets in new doc: 1
 
+Sheets in new doc: 0
 
 PASS (didn't crash)
 
 PASS (didn't crash)

+ 1 - 0
Tests/LibWeb/Text/expected/favicon-in-inactive-document.txt
查看文件 

@@ -0,0 +1 @@
 
+PASS (didn't crash)

+ 10 - 0
Tests/LibWeb/Text/input/favicon-in-inactive-document.html
查看文件 

@@ -0,0 +1,10 @@
 
+<!DOCTYPE html>
 
+<script src="include.js"></script>
 
+<script>
 
+    test(() => {
 
+        const parser = new DOMParser();
 
+        const htmlString = '<head><link rel="icon" type="image/png" href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAAAEElEQVR4nGNgGAWjYBTAAAADEAABPywr7AAAAABJRU5ErkJggg=="></head>';
 
+        const doc = parser.parseFromString(htmlString, "text/html");
 
+        println("PASS (didn't crash)");
 
+    });
 
+</script>

+ 4 - 0
Userland/Libraries/LibWeb/HTML/HTMLLinkElement.cpp
查看文件 

@@ -59,6 +59,10 @@ void HTMLLinkElement::inserted()
 
 {
 
 {
 
     HTMLElement::inserted();
 
     HTMLElement::inserted();
 
 
 
+    if (!document().browsing_context()) {
 
+        return;
 
+    }
 
+
 
     if (m_relationship & Relationship::Stylesheet) {
 
     if (m_relationship & Relationship::Stylesheet) {
 
         // https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet:fetch-and-process-the-linked-resource
 
         // https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet:fetch-and-process-the-linked-resource
 
         // The appropriate times to fetch and process this type of link are:
 
         // The appropriate times to fetch and process this type of link are:

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5