0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-11 17:00:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

UserspaceEmulator: Fix typo in a method name

Browse source 
Changes `load_library_from_adress` to `load_library_from_address`.
This commit is contained in:
Daniel Bertalan 2021-08-01 09:32:01 +02:00 committed by Andreas Kling
parent 7396e4aedc
commit 980f314a03
Notes: sideshowbarker 2024-07-18 07:16:29 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/980f314a030
Pull-request: https://github.com/SerenityOS/serenity/pull/8718
Issue: https://github.com/SerenityOS/serenity/issues/363
Reviewed-by: https://github.com/gunnarbeutner ✅
Reviewed-by: https://github.com/nico
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/DevTools/UserspaceEmulator/Emulator.cpp
View file

@ -278,7 +278,7 @@ void Emulator::handle_repl()
auto insn = X86::Instruction::from_stream(m_cpu, true, true);
// FIXME: This does not respect inlineing
// another way of getting the current function is at need
if (auto const* region = load_library_from_adress(m_cpu.base_eip())) {
if (auto const* region = load_library_from_address(m_cpu.base_eip())) {
auto separator_index = region->name().find(":").value();
String lib_name = region->name().substring(0, separator_index);
String lib_path = lib_name;
@ -400,7 +400,7 @@ MmapRegion const* Emulator::find_text_region(FlatPtr address)
}
// FIXME: This interface isn't the nicest
MmapRegion const* Emulator::load_library_from_adress(FlatPtr address)
MmapRegion const* Emulator::load_library_from_address(FlatPtr address)
{
auto const* region = find_text_region(address);
if (!region)
@ -429,7 +429,7 @@ MmapRegion const* Emulator::load_library_from_adress(FlatPtr address)
String Emulator::create_backtrace_line(FlatPtr address)
{
auto minimal = String::formatted("=={{{}}}== {:p}", getpid(), (void*)address);
auto const* region = load_library_from_adress(address);
auto const* region = load_library_from_address(address);
if (!region)
return minimal;
// FIXME: This is redundant
@ -487,7 +487,7 @@ void Emulator::emit_profile_event(AK::OutputStream& output, StringView event_nam
String Emulator::create_instruction_line(FlatPtr address, X86::Instruction insn)
{
auto minimal = String::formatted("{:p}: {}", (void*)address, insn.to_string(address));
auto const* region = load_library_from_adress(address);
auto const* region = load_library_from_address(address);
if (!region)
return minimal;
// FIXME: This is redundant

2
Userland/DevTools/UserspaceEmulator/Emulator.h
View file

@ -210,7 +210,7 @@ private:
void dispatch_one_pending_signal();
MmapRegion const* find_text_region(FlatPtr address);
MmapRegion const* load_library_from_adress(FlatPtr address);
MmapRegion const* load_library_from_address(FlatPtr address);
String symbol_at(FlatPtr address);
String create_backtrace_line(FlatPtr address);
String create_instruction_line(FlatPtr address, X86::Instruction insn);