LibWeb: Move update_layout() to happen earlier in find_matching_text()

update_layout() need to be invoked before checking if layout node is present, because layout not being updated might be the reason why layout node doesn't exist yet.
Author: https://github.com/kalenikaliaksandr Commit: https://github.com/LadybirdBrowser/ladybird/commit/9754b480faa Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1616 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/awesomekling
2024-10-03 21:53:24 +02:00 · 2024-10-03 21:53:24 +02:00 · 9754b480fa · 2024-10-04 05:08:03 +00:00
commit 9754b480fa
parent 32e79bd12e
1 changed files with 3 additions and 3 deletions
--- a/Userland/Libraries/LibWeb/DOM/Document.cpp
+++ b/Userland/Libraries/LibWeb/DOM/Document.cpp
@ -5337,12 +5337,12 @@ void Document::set_needs_to_refresh_scroll_state(bool b)

 Vector<JS::Handle<DOM::Range>> Document::find_matching_text(String const& query, CaseSensitivity case_sensitivity)
 {
-    if (!layout_node())
-        return {};
-
    // Ensure the layout tree exists before searching for text matches.
    update_layout();

+    if (!layout_node())
+        return {};
+
    auto const& text_blocks = layout_node()->text_blocks();
    if (text_blocks.is_empty())
        return {};