Browse Source

LibGUI+FileManager: Add setting for showing/hiding dotfiles

GUI::FileSystemModel can now be told to display (or not display) files
whose name start with a dot (other than . and ..)
Andreas Kling 5 years ago
parent
commit
9710c9742c

+ 4 - 0
Applications/FileManager/main.cpp

@@ -655,6 +655,10 @@ int run_in_windowed_mode(RefPtr<Core::ConfigFile> config, String initial_locatio
     view_menu.add_action(*view_as_icons_action);
     view_menu.add_action(*view_as_table_action);
     view_menu.add_action(*view_as_columns_action);
+    view_menu.add_separator();
+    view_menu.add_action(GUI::Action::create_checkable("Show dotfiles", { Mod_Ctrl, Key_H }, [&](auto& action) {
+        directory_view.model().set_should_show_dotfiles(action.is_checked());
+    }));
 
     auto& go_menu = menubar->add_menu("Go");
     go_menu.add_action(go_back_action);

+ 9 - 1
Libraries/LibGUI/FileSystemModel.cpp

@@ -91,7 +91,7 @@ void FileSystemModel::Node::traverse_if_needed(const FileSystemModel& model)
     total_size = 0;
 
     auto full_path = this->full_path(model);
-    Core::DirIterator di(full_path, Core::DirIterator::SkipDots);
+    Core::DirIterator di(full_path, model.should_show_dotfiles() ? Core::DirIterator::SkipParentAndBaseDir : Core::DirIterator::SkipDots);
     if (di.has_error()) {
         m_error = di.error();
         fprintf(stderr, "DirIterator: %s\n", di.error_string());
@@ -600,4 +600,12 @@ bool FileSystemModel::accepts_drag(const ModelIndex& index, const StringView& da
     return node.is_directory();
 }
 
+void FileSystemModel::set_should_show_dotfiles(bool show)
+{
+    if (m_should_show_dotfiles == show)
+        return;
+    m_should_show_dotfiles = show;
+    update();
+}
+
 }

+ 5 - 0
Libraries/LibGUI/FileSystemModel.h

@@ -162,6 +162,9 @@ public:
         return Core::DateTime::from_timestamp(timestamp).to_string();
     }
 
+    bool should_show_dotfiles() const { return m_should_show_dotfiles; }
+    void set_should_show_dotfiles(bool);
+
 private:
     FileSystemModel(const StringView& root_path, Mode);
 
@@ -192,6 +195,8 @@ private:
 
     unsigned m_thumbnail_progress { 0 };
     unsigned m_thumbnail_progress_total { 0 };
+
+    bool m_should_show_dotfiles { false };
 };
 
 }