Selaa lähdekoodia

LibJS: Correct FormatTimeZoneOffsetString arg in CreateTemporalTimeZone

This is an editorial change in the Temporal spec (accidentally marked
normative).

See: https://github.com/tc39/proposal-temporal/commit/3039c98
Linus Groh 3 vuotta sitten
vanhempi
commit
96db8a061b
1 muutettua tiedostoa jossa 1 lisäystä ja 2 poistoa
  1. 1 2
      Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp

+ 1 - 2
Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp

@@ -90,8 +90,7 @@ ThrowCompletionOr<TimeZone*> create_temporal_time_zone(GlobalObject& global_obje
     }
     // 5. Else,
     else {
-        // a. Set object.[[Identifier]] to ! FormatTimeZoneOffsetString(identifier).
-        // TODO: `identifier` is wrong here. See: https://github.com/tc39/proposal-temporal/pull/2010
+        // a. Set object.[[Identifier]] to ! FormatTimeZoneOffsetString(offsetNanosecondsResult.[[Value]]).
         object->set_identifier(format_time_zone_offset_string(offset_nanoseconds_result.value()));
 
         // b. Set object.[[OffsetNanoseconds]] to offsetNanosecondsResult.[[Value]].