0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-24 23:23:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Kernel: Make Lock::lock() assert early that we're not in the scheduler

Browse source 
The scheduler is not allowed to take locks, so if that's happening,
we want to make that clear instead of crashing with the more general
"Interrupts disabled while trying to take Lock" error.
This commit is contained in:
Andreas Kling 2019-08-22 09:22:30 +02:00
parent bb74832dd6
commit 933a98f8fa
Notes: sideshowbarker 2024-07-19 12:34:10 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/933a98f8fac
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Lock.cpp
View file

@ -2,12 +2,12 @@
void Lock::lock() void Lock::lock()
{ {
ASSERT(!Scheduler::is_active());
if (!are_interrupts_enabled()) { if (!are_interrupts_enabled()) {
kprintf("Interrupts disabled when trying to take Lock{%s}\n", m_name); kprintf("Interrupts disabled when trying to take Lock{%s}\n", m_name);
dump_backtrace(); dump_backtrace();
hang(); hang();
} }
ASSERT(!Scheduler::is_active());
for (;;) { for (;;) {
if (CAS(&m_lock, 1, 0) == 0) { if (CAS(&m_lock, 1, 0) == 0) {
if (!m_holder || m_holder == current) { if (!m_holder || m_holder == current) {