LibWeb/WebAudio: Set all the params in PannerNode constructor

This commit is contained in:
Pavel Shliak 2024-12-17 01:40:45 +04:00 committed by Alexander Kalenik
parent 884599f1df
commit 9232dcbde5
Notes: github-actions[bot] 2024-12-18 09:20:53 +00:00
2 changed files with 7 additions and 6 deletions

View file

@ -61,12 +61,14 @@ WebIDL::ExceptionOr<GC::Ref<PannerNode>> PannerNode::construct_impl(JS::Realm& r
PannerNode::PannerNode(JS::Realm& realm, GC::Ref<BaseAudioContext> context, PannerOptions const& options) PannerNode::PannerNode(JS::Realm& realm, GC::Ref<BaseAudioContext> context, PannerOptions const& options)
: AudioNode(realm, context) : AudioNode(realm, context)
, m_panning_model(options.panning_model)
, m_position_x(AudioParam::create(realm, options.position_x, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate)) , m_position_x(AudioParam::create(realm, options.position_x, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate))
, m_position_y(AudioParam::create(realm, options.position_y, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate)) , m_position_y(AudioParam::create(realm, options.position_y, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate))
, m_position_z(AudioParam::create(realm, options.position_z, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate)) , m_position_z(AudioParam::create(realm, options.position_z, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate))
, m_orientation_x(AudioParam::create(realm, options.orientation_x, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate)) , m_orientation_x(AudioParam::create(realm, options.orientation_x, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate))
, m_orientation_y(AudioParam::create(realm, options.orientation_y, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate)) , m_orientation_y(AudioParam::create(realm, options.orientation_y, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate))
, m_orientation_z(AudioParam::create(realm, options.orientation_z, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate)) , m_orientation_z(AudioParam::create(realm, options.orientation_z, NumericLimits<float>::lowest(), NumericLimits<float>::max(), Bindings::AutomationRate::ARate))
, m_distance_model(options.distance_model)
, m_ref_distance(options.ref_distance) , m_ref_distance(options.ref_distance)
, m_max_distance(options.max_distance) , m_max_distance(options.max_distance)
, m_rolloff_factor(options.rolloff_factor) , m_rolloff_factor(options.rolloff_factor)

View file

@ -2,8 +2,7 @@ Harness status: OK
Found 125 tests Found 125 tests
121 Pass 125 Pass
4 Fail
Pass # AUDIT TASK RUNNER STARTED. Pass # AUDIT TASK RUNNER STARTED.
Pass Executing "initialize" Pass Executing "initialize"
Pass Executing "invalid constructor" Pass Executing "invalid constructor"
@ -110,14 +109,14 @@ Pass < [test AudioNodeOptions] All assertions passed. (total 54 assertions)
Pass > [constructor with options] Pass > [constructor with options]
Pass node = new PannerNode(c, {"panningModel":"HRTF","positionX":1.4142135623730951,"positionY":2.8284271247461903,"positionZ":4.242640687119286,"orientationX":-1.4142135623730951,"orientationY":-2.8284271247461903,"orientationZ":-4.242640687119286,"distanceModel":"linear","refDistance":3.141592653589793,"maxDistance":6.283185307179586,"rolloffFactor":9.42477796076938,"coneInnerAngle":12.566370614359172,"coneOuterAngle":15.707963267948966,"coneOuterGain":0.3141592653589793}) did not throw an exception. Pass node = new PannerNode(c, {"panningModel":"HRTF","positionX":1.4142135623730951,"positionY":2.8284271247461903,"positionZ":4.242640687119286,"orientationX":-1.4142135623730951,"orientationY":-2.8284271247461903,"orientationZ":-4.242640687119286,"distanceModel":"linear","refDistance":3.141592653589793,"maxDistance":6.283185307179586,"rolloffFactor":9.42477796076938,"coneInnerAngle":12.566370614359172,"coneOuterAngle":15.707963267948966,"coneOuterGain":0.3141592653589793}) did not throw an exception.
Pass node instanceof PannerNode is equal to true. Pass node instanceof PannerNode is equal to true.
Fail X node.panningModel is not equal to HRTF. Got equalpower. Pass node.panningModel is equal to HRTF.
Pass node.positionX.value is equal to 1.4142135381698608. Pass node.positionX.value is equal to 1.4142135381698608.
Pass node.positionY.value is equal to 2.8284270763397217. Pass node.positionY.value is equal to 2.8284270763397217.
Pass node.positionZ.value is equal to 4.242640495300293. Pass node.positionZ.value is equal to 4.242640495300293.
Pass node.orientationX.value is equal to -1.4142135381698608. Pass node.orientationX.value is equal to -1.4142135381698608.
Pass node.orientationY.value is equal to -2.8284270763397217. Pass node.orientationY.value is equal to -2.8284270763397217.
Pass node.orientationZ.value is equal to -4.242640495300293. Pass node.orientationZ.value is equal to -4.242640495300293.
Fail X node.distanceModel is not equal to linear. Got inverse. Pass node.distanceModel is equal to linear.
Pass node.refDistance is equal to 3.141592653589793. Pass node.refDistance is equal to 3.141592653589793.
Pass node.maxDistance is equal to 6.283185307179586. Pass node.maxDistance is equal to 6.283185307179586.
Pass node.rolloffFactor is equal to 9.42477796076938. Pass node.rolloffFactor is equal to 9.42477796076938.
@ -127,5 +126,5 @@ Pass node.coneOuterGain is equal to 0.3141592653589793.
Pass node.channelCount is equal to 2. Pass node.channelCount is equal to 2.
Pass node.channelCountMode is equal to clamped-max. Pass node.channelCountMode is equal to clamped-max.
Pass node.channelInterpretation is equal to speakers. Pass node.channelInterpretation is equal to speakers.
Fail < [constructor with options] 2 out of 19 assertions were failed. Pass < [constructor with options] All assertions passed. (total 19 assertions)
Fail # AUDIT TASK RUNNER FINISHED: 1 out of 5 tasks were failed. Pass # AUDIT TASK RUNNER FINISHED: 5 tasks ran successfully.