Selaa lähdekoodia

LibWeb/CSS: Remove unwanted newline from list serialization

Gets us 1 subtest pass.
Sam Atkins 8 kuukautta sitten
vanhempi
commit
917d659f8b

+ 4 - 1
Libraries/LibWeb/CSS/Serialize.h

@@ -31,14 +31,17 @@ String serialize_a_string(StringView string);
 String serialize_a_url(StringView url);
 String serialize_a_srgb_value(Color color);
 
+// https://www.w3.org/TR/cssom/#serialize-a-comma-separated-list
 template<typename T, typename SerializeItem>
 void serialize_a_comma_separated_list(StringBuilder& builder, Vector<T> const& items, SerializeItem serialize_item)
 {
+    // To serialize a comma-separated list concatenate all items of the list in list order
+    // while separating them by ", ", i.e., COMMA (U+002C) followed by a single SPACE (U+0020).
     for (size_t i = 0; i < items.size(); i++) {
         auto& item = items.at(i);
         serialize_item(builder, item);
         if ((i + 1) < items.size()) {
-            builder.append(",\n"sv);
+            builder.append(", "sv);
         }
     }
 }

+ 3 - 3
Tests/LibWeb/Text/expected/wpt-import/css/cssom/serialize-values.txt

@@ -6,8 +6,8 @@ Rerun
 
 Found 687 tests
 
-463 Pass
-224 Fail
+464 Pass
+223 Fail
 Details
 Result	Test Name	MessagePass	background-attachment: scroll	
 Pass	background-attachment: fixed	
@@ -331,7 +331,7 @@ Fail	content: url("http://localhost/")
 Fail	content: url(http://localhost/)	
 Fail	content: counter(par-num)	
 Fail	content: counter(par-num, decimal)	
-Fail	content: counter(par-num, upper-roman)	
+Pass	content: counter(par-num, upper-roman)	
 Pass	content: attr(foo-bar)	
 Pass	content: attr(foo_bar)	
 Fail	content: attr(|bar)