diff --git a/Meta/gn/README.md b/Meta/gn/README.md index 99fa224206b..faa964ad4dc 100644 --- a/Meta/gn/README.md +++ b/Meta/gn/README.md @@ -1,9 +1,30 @@ # gn build for SerenityOS and Ladybird -Warning The GN build is experimental and best-effort. It might not work, and if you use it you're expected to feel comfortable to unbreak it if necessary. Serenity's official build system is CMake, if in doubt use that. If you add files, you're expected to update the CMake build but you don't need to update GN build files. Reviewers should not ask authors to update GN build files. Keeping the GN build files up-to-date is on the people who use the GN build. +Warning! The GN build is experimental and best-effort. It might not work, and if you use it you're expected to feel comfortable to unbreak it if necessary. Serenity's official build system is CMake, if in doubt use that. If you add files, you're expected to update the CMake build but you don't need to update GN build files. Reviewers should not ask authors to update GN build files. Keeping the GN build files up-to-date is on the people who use the GN build. GN is a metabuild system. It always creates ninja files, but it can create some IDE projects (MSVC, Xcode, ...) which then shell out to ninja for the actual build. This is a good [overview of GN](https://docs.google.com/presentation/d/15Zwb53JcncHfEwHpnG_PoIbbzQ3GQi_cpujYwbpcbZo/edit#slide=id.g119d702868_0_12). For more information, motivation, philosophy, and inspriation, see the LLVM documentation on its [GN build](https://github.com/llvm/llvm-project/tree/main/llvm/utils/gn#quick-start) + +# Typical gn args + +On macOS, the default args should work out of the box. For compiling Ladybird there won't be any tailoring needed if you have Qt6 installed via homebrew and the Xcode tools installed. + +On Ubuntu, it's likely that the default ``cc`` and ``cxx`` will not be able to compile the project. For compiling Ladybird, a typical ``args.gn`` might look like the below: + +args.gn +```gn +# Set build arguments here. See `gn help buildargs`. +# Chosen clang must be >= version 15.0.0 +host_cc="clang" +host_cxx="clang++" +is_clang=true +use_lld=true +qt_install_headers="/usr/include/x86_64-linux-gnu/qt6/" +qt_install_lib="/usr/lib/x86_64-linux-gnu" +qt_install_libexec="/usr/lib/qt6/libexec/" +``` + +As with any gn project, ``gn args --list`` is your best friend. diff --git a/Meta/gn/secondary/Userland/Libraries/LibWeb/CSS/BUILD.gn b/Meta/gn/secondary/Userland/Libraries/LibWeb/CSS/BUILD.gn index 2ab81191367..ce75d79619c 100644 --- a/Meta/gn/secondary/Userland/Libraries/LibWeb/CSS/BUILD.gn +++ b/Meta/gn/secondary/Userland/Libraries/LibWeb/CSS/BUILD.gn @@ -16,7 +16,7 @@ source_set("CSS") { "CSSKeyframeRule.cpp", "CSSKeyframesRule.cpp", "CSSMediaRule.cpp", - "CSSNumerictype.cpp", + "CSSNumericType.cpp", "CSSRule.cpp", "CSSRuleList.cpp", "CSSStyleDeclaration.cpp",