0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Fail CSS color parse for "rgba(123, 123, 123, "

Browse source 
This matches the behavior of other browsers and fixes a WPT test.
This commit is contained in:
Andreas Kling 2024-10-04 14:26:53 +02:00 • committed by Andreas Kling
parent 4590c081c2
commit 902586a21d
Notes: github-actions[bot] 2024-10-04 18:02:20 +00:00
3 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/canvas/fillStyle-bogus-rgba-color.txt Normal file
View file

@ -0,0 +1,2 @@
#008000
#008000

12
Tests/LibWeb/Text/input/canvas/fillStyle-bogus-rgba-color.html Normal file
View file

@ -0,0 +1,12 @@
<script src="../include.js"></script>
<canvas id="c" width=300 height=300></canvas>
<script>
test(() => {
let x = c.getContext("2d");
x.fillStyle = 'green';
println(x.fillStyle);
x.fillStyle = 'rgba(255, 0, 0, ';
println(x.fillStyle);
c.remove();
});
</script>

3
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -2848,6 +2848,9 @@ RefPtr<CSSStyleValue> Parser::parse_rgb_color_value(TokenStream<ComponentValue>&
alpha = parse_number_percentage_value(inner_tokens);
if (!alpha)
return {};
inner_tokens.skip_whitespace();
if (inner_tokens.has_next_token())