Quellcode durchsuchen

LibX86: Fix duplicate '+' in SIB byte disassembly

For SIB bytes with base but no index, we were emitting two '+' chars
which looked very off.
Andreas Kling vor 5 Jahren
Ursprung
Commit
8daddcfa0a
1 geänderte Dateien mit 2 neuen und 1 gelöschten Zeilen
  1. 2 1
      Libraries/LibX86/Instruction.cpp

+ 2 - 1
Libraries/LibX86/Instruction.cpp

@@ -1170,7 +1170,8 @@ static String sib_to_string(u8 rm, u8 sib)
         builder.append(scale);
         builder.append(scale);
     } else {
     } else {
         builder.append(base);
         builder.append(base);
-        builder.append('+');
+        if (!base.is_empty() && !index.is_empty())
+            builder.append('+');
         builder.append(index);
         builder.append(index);
         builder.append(scale);
         builder.append(scale);
     }
     }