浏览代码

Kernel: Avoid unnecessary allocations for TTY::tty_name()

Gunnar Beutner 4 年之前
父节点
当前提交
8b079a6b0d
共有 4 个文件被更改,包括 4 次插入4 次删除
  1. 1 1
      Kernel/TTY/SlavePTY.cpp
  2. 1 1
      Kernel/TTY/SlavePTY.h
  3. 1 1
      Kernel/TTY/TTY.h
  4. 1 1
      Kernel/TTY/VirtualConsole.h

+ 1 - 1
Kernel/TTY/SlavePTY.cpp

@@ -31,7 +31,7 @@ SlavePTY::~SlavePTY()
     DevPtsFS::unregister_slave_pty(*this);
     DevPtsFS::unregister_slave_pty(*this);
 }
 }
 
 
-String SlavePTY::tty_name() const
+String const& SlavePTY::tty_name() const
 {
 {
     return m_tty_name;
     return m_tty_name;
 }
 }

+ 1 - 1
Kernel/TTY/SlavePTY.h

@@ -26,7 +26,7 @@ public:
 
 
 private:
 private:
     // ^TTY
     // ^TTY
-    virtual String tty_name() const override;
+    virtual String const& tty_name() const override;
     virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override;
     virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override;
     virtual void echo(u8) override;
     virtual void echo(u8) override;
 
 

+ 1 - 1
Kernel/TTY/TTY.h

@@ -26,7 +26,7 @@ public:
     virtual int ioctl(FileDescription&, unsigned request, FlatPtr arg) override final;
     virtual int ioctl(FileDescription&, unsigned request, FlatPtr arg) override final;
     virtual String absolute_path(const FileDescription&) const override { return tty_name(); }
     virtual String absolute_path(const FileDescription&) const override { return tty_name(); }
 
 
-    virtual String tty_name() const = 0;
+    virtual String const& tty_name() const = 0;
 
 
     unsigned short rows() const { return m_rows; }
     unsigned short rows() const { return m_rows; }
     unsigned short columns() const { return m_columns; }
     unsigned short columns() const { return m_columns; }

+ 1 - 1
Kernel/TTY/VirtualConsole.h

@@ -35,7 +35,7 @@ private:
 
 
     // ^TTY
     // ^TTY
     virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override;
     virtual ssize_t on_tty_write(const UserOrKernelBuffer&, ssize_t) override;
-    virtual String tty_name() const override { return m_tty_name; }
+    virtual String const& tty_name() const override { return m_tty_name; }
     virtual void echo(u8) override;
     virtual void echo(u8) override;
 
 
     // ^TerminalClient
     // ^TerminalClient