0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel: Fix regression in VFS::symlink

Browse source 
The create_child method should be called with basename, not the full
linkpath.
This commit is contained in:
Max Wipfli 2021-07-05 19:08:31 +02:00 • committed by Andreas Kling
parent 502436f9fc
commit 8a295299f3
Notes: sideshowbarker 2024-07-18 10:22:27 +09:00
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/VirtualFileSystem.cpp
View file

@ -713,8 +713,8 @@ KResult VFS::symlink(StringView target, StringView linkpath, Custody& base)
return EROFS;
auto basename = LexicalPath::basename(linkpath);
dbgln_if(VFS_DEBUG, "VFS::symlink: '{}' (-> '{}') in {}", linkpath, target, parent_inode.identifier());
auto inode_or_error = parent_inode.create_child(linkpath, S_IFLNK | 0644, 0, current_process->euid(), current_process->egid());
dbgln_if(VFS_DEBUG, "VFS::symlink: '{}' (-> '{}') in {}", basename, target, parent_inode.identifier());
auto inode_or_error = parent_inode.create_child(basename, S_IFLNK | 0644, 0, current_process->euid(), current_process->egid());
if (inode_or_error.is_error())
return inode_or_error.error();
auto& inode = inode_or_error.value();