0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Don't resolve CSS property values for unconnected elements

Browse source 
While it's possible to getComputedStyle() on an unconnected element,
the resulting object is not supposed to have any values, since we can't
resolve style without a document root anyway.

This fixes a crash on https://bandcamp.com
This commit is contained in:
Andreas Kling 2023-05-10 15:33:10 +02:00
parent 4005793e79
commit 89ba7246dd
Notes: sideshowbarker 2024-07-17 02:59:43 +09:00
3 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Tests/LibWeb/Layout/expected/getComputedStyle-on-unconnected-element.txt Normal file
View file

@ -0,0 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x37.835937 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x21.835937 children: inline
line 0 width: 362.617187, height: 21.835937, bottom: 21.835937, baseline: 16.914062
frag 0 from TextNode start: 0, length: 35, rect: [8,8 362.617187x21.835937]
"This test passes if we don't crash."
TextNode <#text>

11
Tests/LibWeb/Layout/input/getComputedStyle-on-unconnected-element.html Normal file
View file

@ -0,0 +1,11 @@
<!doctype html><style>
* { font: 20px SerenitySans; }
</style><script>
let fragment = document.createDocumentFragment()
let a = document.createElement("a")
fragment.appendChild(a)
let b = document.createElement("b")
a.appendChild(b)
window.getComputedStyle(b).display
</script>
This test passes if we don't crash.

5
Userland/Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.cpp
View file

@ -666,6 +666,11 @@ ErrorOr<RefPtr<StyleValue const>> ResolvedCSSStyleDeclaration::style_value_for_p
Optional<StyleProperty> ResolvedCSSStyleDeclaration::property(PropertyID property_id) const
{
// https://www.w3.org/TR/cssom-1/#dom-window-getcomputedstyle
// NOTE: This is a partial enforcement of step 5 ("If elt is connected, ...")
if (!m_element->is_connected())
return {};
if (CSS::property_affects_layout(property_id)) {
const_cast<DOM::Document&>(m_element->document()).update_layout();
} else {