Jelajahi Sumber

LibWeb: Make non-absolute values for line-height fall back to font-size

When using bitmap fonts, the computed *font* that we're using may be
smaller than the font-size property asked for. We can still honor the
font-size value in layout calculations.
Andreas Kling 3 tahun lalu
induk
melakukan
88c32836d8
1 mengubah file dengan 4 tambahan dan 1 penghapusan
  1. 4 1
      Userland/Libraries/LibWeb/CSS/StyleProperties.cpp

+ 4 - 1
Userland/Libraries/LibWeb/CSS/StyleProperties.cpp

@@ -98,7 +98,10 @@ float StyleProperties::line_height(const Layout::Node& layout_node) const
 {
     auto line_height_length = length_or_fallback(CSS::PropertyID::LineHeight, Length::make_auto());
     if (line_height_length.is_absolute())
-        return (float)line_height_length.to_px(layout_node);
+        return line_height_length.to_px(layout_node);
+    auto font_size = length_or_fallback(CSS::PropertyID::FontSize, Length::make_auto());
+    if (font_size.is_absolute())
+        return font_size.to_px(layout_node);
     return (float)computed_font().glyph_height() * 1.4f;
 }