Sfoglia il codice sorgente

LibGUI: Use normalized TextRange for early empty string check

Fixes #6141. Allows to copy "backward" selections.
Maciej Zygmanowski 4 anni fa
parent
commit
8646f8f4ad
1 ha cambiato i file con 2 aggiunte e 2 eliminazioni
  1. 2 2
      Userland/Libraries/LibGUI/TextDocument.cpp

+ 2 - 2
Userland/Libraries/LibGUI/TextDocument.cpp

@@ -343,9 +343,9 @@ String TextDocument::text() const
 
 
 String TextDocument::text_in_range(const TextRange& a_range) const
 String TextDocument::text_in_range(const TextRange& a_range) const
 {
 {
-    if (is_empty() || line_count() < a_range.end().line() - a_range.start().line() || line(a_range.start().line()).is_empty())
-        return String("");
     auto range = a_range.normalized();
     auto range = a_range.normalized();
+    if (is_empty() || line_count() < range.end().line() - range.start().line() || line(range.start().line()).is_empty())
+        return String("");
 
 
     StringBuilder builder;
     StringBuilder builder;
     for (size_t i = range.start().line(); i <= range.end().line(); ++i) {
     for (size_t i = range.start().line(); i <= range.end().line(); ++i) {