ClangPlugins: Remove confusing hasType check for lambda capture types

This check asserts that templated types will never escape. Which doesn't hold up at all in practice.
Author: https://github.com/ADKaster Commit: https://github.com/LadybirdBrowser/ladybird/commit/85b87508bf1 Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2860
2024-12-09 19:51:05 -07:00 · 2024-12-09 19:51:05 -07:00 · 85b87508bf · 2024-12-10 06:13:49 +00:00
commit 85b87508bf
parent 2f38c83caf
1 changed files with 1 additions and 6 deletions
--- a/Meta/Lagom/ClangPlugins/LambdaCapturePluginAction.cpp
+++ b/Meta/Lagom/ClangPlugins/LambdaCapturePluginAction.cpp
@ -84,12 +84,7 @@ public:
                                unless(hasParent(
                                    // <lambda struct>::operator()(...)
                                    cxxOperatorCallExpr(has(declRefExpr(to(equalsBoundNode("lambda")))))))))),
-                        parmVarDecl(
+                        parmVarDecl(hasAnnotation("serenity::escaping")).bind("lambda-param-ref")))),
                            allOf(
                                // It's important that the parameter has a RecordType, as a templated type can never escape its function
                                hasType(cxxRecordDecl()),
                                hasAnnotation("serenity::escaping")))
                            .bind("lambda-param-ref")))),
            this);
    }