Преглед изворни кода

headless-browser: Don't choke on subframe load completions

This didn't break any existing tests, but I have to do this for an
upcoming test to not bring everything down.
Andreas Kling пре 1 година
родитељ
комит
8586897928
1 измењених фајлова са 3 додато и 1 уклоњено
  1. 3 1
      Userland/Utilities/headless-browser.cpp

+ 3 - 1
Userland/Utilities/headless-browser.cpp

@@ -303,7 +303,9 @@ static ErrorOr<TestResult> run_dump_test(HeadlessWebContentView& view, StringVie
     } else if (mode == TestMode::Text) {
     } else if (mode == TestMode::Text) {
 
 
         view.on_load_finish = [&](auto const& loaded_url) {
         view.on_load_finish = [&](auto const& loaded_url) {
-            VERIFY(url.equals(loaded_url, URL::ExcludeFragment::Yes));
+            // NOTE: We don't want subframe loads to trigger the test finish.
+            if (!url.equals(loaded_url, URL::ExcludeFragment::Yes))
+                return;
             did_finish_loading = true;
             did_finish_loading = true;
             if (did_finish_test)
             if (did_finish_test)
                 loop.quit(0);
                 loop.quit(0);