We use cookies to ensure you get the best experience on our website
首页 发现 帮助
注册 登录
0ct0pu5
/
ladybird
1
0
派生 0
文件 工单管理 0 合并请求 0 Wiki
浏览代码

LibWeb/CSS: Stop invalidating style when setting an animation's effect

This reverts 6d25bf3aac3a10bd741f4193e790ab7886462b93

Invalidating the style here means that transitions can cause an element
to leave style computation with its "needs style update" flag set to
true. This then causes a VERIFY to fail in the TreeBuilder.

This invalidation does not otherwise seem to have any effect. The
original commit suggests this was to fix a bug, but it's not clear what
bug that was. If it reappears, we can try to solve the issue in a
different way.
Sam Atkins 10 月之前
父节点
63d9ed9d8c
当前提交
81596b4145
共有 4 个文件被更改，包括 19 次插入 和 4 次删除
合并视图 显示文件统计
  1. 1 0
      Tests/LibWeb/Text/expected/css/transition-style-invalidation-crash.txt
  2. 18 0
      Tests/LibWeb/Text/input/css/transition-style-invalidation-crash.html
  3. 0 3
      Userland/Libraries/LibWeb/Animations/AnimationEffect.cpp
  4. 0 1
      Userland/Libraries/LibWeb/DOM/Node.h

+ 1 - 0
Tests/LibWeb/Text/expected/css/transition-style-invalidation-crash.txt
查看文件 

@@ -0,0 +1 @@
 
+PASS (didn't crash)

+ 18 - 0
Tests/LibWeb/Text/input/css/transition-style-invalidation-crash.html
查看文件 

@@ -0,0 +1,18 @@
 
+<!DOCTYPE html>
 
+<script src="../include.js"></script>
 
+<style>
 
+    .foo {
 
+        opacity: 0;
 
+        transition: opacity 200ms;
 
+    }
 
+</style>
 
+<ul>
 
+    <li class="foo"></li>
 
+    <li></li>
 
+</ul>
 
+<video src=""></video>
 
+<script>
 
+    test(() => {
 
+        println("PASS (didn't crash)");
 
+    });
 
+</script>

+ 0 - 3
Userland/Libraries/LibWeb/Animations/AnimationEffect.cpp
查看文件 

@@ -11,7 +11,6 @@
 
 #include <LibWeb/Bindings/AnimationEffectPrototype.h>
 
 #include <LibWeb/Bindings/AnimationEffectPrototype.h>
 
 #include <LibWeb/Bindings/Intrinsics.h>
 
 #include <LibWeb/Bindings/Intrinsics.h>
 
 #include <LibWeb/CSS/Parser/Parser.h>
 
 #include <LibWeb/CSS/Parser/Parser.h>
 
-#include <LibWeb/DOM/Element.h>
 
 #include <LibWeb/WebIDL/ExceptionOr.h>
 
 #include <LibWeb/WebIDL/ExceptionOr.h>
 
 
 
 namespace Web::Animations {
 
 namespace Web::Animations {
 
@@ -205,8 +204,6 @@ WebIDL::ExceptionOr<void> AnimationEffect::update_timing(OptionalEffectTiming ti
 
 void AnimationEffect::set_associated_animation(JS::GCPtr<Animation> value)
 
 void AnimationEffect::set_associated_animation(JS::GCPtr<Animation> value)
 
 {
 
 {
 
     m_associated_animation = value;
 
     m_associated_animation = value;
 
-    if (auto* target = this->target())
 
-        target->invalidate_style(DOM::StyleInvalidationReason::AnimationEffectSetAssociatedAnimation);
 
 }
 
 }
 
 
 
 // https://www.w3.org/TR/web-animations-1/#animation-direction
 
 // https://www.w3.org/TR/web-animations-1/#animation-direction

+ 0 - 1
Userland/Libraries/LibWeb/DOM/Node.h
查看文件 

@@ -54,7 +54,6 @@ enum class FragmentSerializationMode {
 
 
 
 #define ENUMERATE_STYLE_INVALIDATION_REASONS(X)     \
 
 #define ENUMERATE_STYLE_INVALIDATION_REASONS(X)     \
 
     X(AdoptedStyleSheetsList)                       \
 
     X(AdoptedStyleSheetsList)                       \
 
-    X(AnimationEffectSetAssociatedAnimation)        \
 
     X(CSSFontLoaded)                                \
 
     X(CSSFontLoaded)                                \
 
     X(CSSImportRule)                                \
 
     X(CSSImportRule)                                \
 
     X(DidLoseFocus)                                 \
 
     X(DidLoseFocus)                                 \

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5