瀏覽代碼

CMake: Add back stricter warnings used in Serenity builds

These used to be enabled in `serenity_compile_options.cmake` for
Serenity builds and were removed in 9b05fb98. This is a slightly more
conservative subset of those, with ones that are enabled by default
omitted.

This should prevent our code quality regressing in the long run.
Daniel Bertalan 1 年之前
父節點
當前提交
7fe82a1cda
共有 2 個文件被更改,包括 6 次插入2 次删除
  1. 5 1
      Meta/CMake/common_compile_options.cmake
  2. 1 1
      Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp

+ 5 - 1
Meta/CMake/common_compile_options.cmake

@@ -19,8 +19,12 @@ else()
     add_compile_options(-ffp-contract=off)
     add_compile_options(-ffp-contract=off)
 endif()
 endif()
 
 
-add_compile_options(-Wno-invalid-offsetof)
+add_compile_options(-Wcast-qual)
+add_compile_options(-Wformat=2)
+add_compile_options(-Wimplicit-fallthrough)
+add_compile_options(-Wsuggest-override)
 
 
+add_compile_options(-Wno-invalid-offsetof)
 add_compile_options(-Wno-unknown-warning-option)
 add_compile_options(-Wno-unknown-warning-option)
 add_compile_options(-Wno-unused-command-line-argument)
 add_compile_options(-Wno-unused-command-line-argument)
 
 

+ 1 - 1
Userland/Libraries/LibGfx/ImageFormats/JPEGWriter.cpp

@@ -89,7 +89,7 @@ ErrorOr<void> JPEGWriter::encode_impl(Stream& stream, auto const& bitmap, Option
 
 
     while (cinfo.next_scanline < cinfo.image_height) {
     while (cinfo.next_scanline < cinfo.image_height) {
         auto const* row_ptr = reinterpret_cast<u8 const*>(bitmap.scanline(cinfo.next_scanline));
         auto const* row_ptr = reinterpret_cast<u8 const*>(bitmap.scanline(cinfo.next_scanline));
-        JSAMPROW row_pointer = (JSAMPROW)row_ptr;
+        JSAMPROW row_pointer = const_cast<JSAMPROW>(row_ptr);
         jpeg_write_scanlines(&cinfo, &row_pointer, 1);
         jpeg_write_scanlines(&cinfo, &row_pointer, 1);
     }
     }