Преглед на файлове

Kernel: Encapsulate assignment of socket origin/acceptor credentials

Andreas Kling преди 3 години
родител
ревизия
7f96288535
променени са 3 файла, в които са добавени 16 реда и са изтрити 6 реда
  1. 1 3
      Kernel/Net/LocalSocket.cpp
  2. 12 3
      Kernel/Net/Socket.cpp
  3. 3 0
      Kernel/Net/Socket.h

+ 1 - 3
Kernel/Net/LocalSocket.cpp

@@ -62,9 +62,7 @@ KResultOr<SocketPair> LocalSocket::create_connected_pair(int type)
     socket->m_address.sun_family = AF_LOCAL;
     memcpy(socket->m_address.sun_path, "[socketpair]", 13);
 
-    auto& process = Process::current();
-    socket->m_acceptor = { process.pid().value(), process.uid().value(), process.gid().value() };
-
+    socket->set_acceptor(Process::current());
     socket->set_connected(true);
     socket->set_connect_side_role(Role::Connected);
     socket->m_role = Role::Accepted;

+ 12 - 3
Kernel/Net/Socket.cpp

@@ -38,8 +38,7 @@ Socket::Socket(int domain, int type, int protocol)
     , m_type(type)
     , m_protocol(protocol)
 {
-    auto& process = Process::current();
-    m_origin = { process.pid().value(), process.uid().value(), process.gid().value() };
+    set_origin(Process::current());
 }
 
 Socket::~Socket()
@@ -62,7 +61,7 @@ RefPtr<Socket> Socket::accept()
     auto client = m_pending.take_first();
     VERIFY(!client->is_connected());
     auto& process = Process::current();
-    client->m_acceptor = { process.pid().value(), process.uid().value(), process.gid().value() };
+    client->set_acceptor(process);
     client->m_connected = true;
     client->m_role = Role::Accepted;
     if (!m_pending.is_empty())
@@ -274,4 +273,14 @@ void Socket::set_connected(bool connected)
     evaluate_block_conditions();
 }
 
+void Socket::set_origin(Process const& process)
+{
+    m_origin = { process.pid().value(), process.uid().value(), process.gid().value() };
+}
+
+void Socket::set_acceptor(Process const& process)
+{
+    m_acceptor = { process.pid().value(), process.uid().value(), process.gid().value() };
+}
+
 }

+ 3 - 0
Kernel/Net/Socket.h

@@ -137,6 +137,9 @@ protected:
         return error;
     }
 
+    void set_origin(Process const&);
+    void set_acceptor(Process const&);
+
 protected:
     ucred m_origin { 0, 0, 0 };
     ucred m_acceptor { 0, 0, 0 };