0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Treat null as empty string in CSSStyleDeclaration::internal_set

Browse source 
Spec defines `[LegacyNullToEmptyString]` on `value` argument of
`setProperty` but since `internal_set` calls `setProperty` directly
instead of using IDL generated binding, we need to make sure that null
is treated as empty string.

Fixes items grid loading on https://d.rsms.me/stuff/
This commit is contained in:
Aliaksandr Kalenik 2024-01-21 20:00:52 +01:00 • committed by Andreas Kling
parent e9e1ee11d4
commit 7e2308d290
Notes: sideshowbarker 2024-07-17 09:41:18 +09:00
3 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Tests/LibWeb/Layout/expected/misc/set-display-null.txt Normal file
View file

@ -0,0 +1,9 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x116 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x100 children: not-inline
BlockContainer <div#box> at (8,8) content-size 100x100 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x116]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x100]
PaintableWithLines (BlockContainer<DIV>#box) [8,8 100x100]

9
Tests/LibWeb/Layout/input/misc/set-display-null.html Normal file
View file

@ -0,0 +1,9 @@
<!DOCTYPE html><style>
#box {
width: 100px;
height: 100px;
background-color: magenta;
}
</style><body><div id="box"></div></body><script>
document.getElementById("box").style.display = "none";
document.getElementById("box").style.display = null;</script>

2
Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.cpp
View file

@ -432,7 +432,7 @@ JS::ThrowCompletionOr<bool> CSSStyleDeclaration::internal_set(JS::PropertyKey co
if (property_id == CSS::PropertyID::Invalid)
return Base::internal_set(name, value, receiver, cacheable_metadata);
auto css_text = TRY(value.to_string(vm));
auto css_text = value.is_null() ? String {} : TRY(value.to_string(vm));
TRY(Bindings::throw_dom_exception_if_needed(vm, [&] { return set_property(property_id, css_text); }));
return true;