0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-03 04:50:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

AK: Cleanup missing includes and #ifdef evaluation

Browse source 
Problem:
- Several files have missing includes. This results in complaints from
  `clang-tidy`.
- `#ifdef` is followed by `#elif <value>` which evaluates to `0`.

Solution:
- Add missing includes.
- Change to `#elif defined(<value>)`.
This commit is contained in:
Lenny Maiorani 2020-11-21 18:02:56 -07:00 committed by Andreas Kling
parent bbc0487ced
commit 7d8a9bdb1e
Notes: sideshowbarker 2024-07-19 01:19:50 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/7d8a9bdb1ea
Pull-request: https://github.com/SerenityOS/serenity/pull/4134
5 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
AK/Buffered.h
View file

@ -26,7 +26,12 @@
#pragma once
#include <AK/Noncopyable.h>
#include <AK/Span.h>
#include <AK/StdLibExtras.h>
#include <AK/Stream.h>
#include <AK/Types.h>
#include <AK/kmalloc.h>
namespace AK {

1
AK/Optional.h
View file

@ -30,6 +30,7 @@
#include <AK/Platform.h>
#include <AK/StdLibExtras.h>
#include <AK/Types.h>
#include <AK/kmalloc.h>
namespace AK {

1
AK/Singleton.h
View file

@ -28,6 +28,7 @@
#include <AK/Assertions.h>
#include <AK/Atomic.h>
#include <AK/Noncopyable.h>
#include <AK/kmalloc.h>
#ifdef KERNEL
# include <Kernel/Arch/i386/CPU.h>

4
AK/SinglyLinkedListWithCount.h
View file

@ -96,12 +96,12 @@ public:
return List::contains_slow(value);
}
using Iterator = List::Iterator;
using Iterator = typename List::Iterator;
friend Iterator;
Iterator begin() { return List::begin(); }
Iterator end() { return List::end(); }
using ConstIterator = List::ConstIterator;
using ConstIterator = typename List::ConstIterator;
friend ConstIterator;
ConstIterator begin() const { return List::begin(); }
ConstIterator end() const { return List::end(); }

2
AK/StackInfo.cpp
View file

@ -30,7 +30,7 @@
#ifdef __serenity__
# include <serenity.h>
#elif __linux__ or __APPLE__
#elif defined(__linux__) or defined(__APPLE__)
# include <pthread.h>
#endif