Browse Source

AK: Cleanup missing includes and #ifdef evaluation

Problem:
- Several files have missing includes. This results in complaints from
  `clang-tidy`.
- `#ifdef` is followed by `#elif <value>` which evaluates to `0`.

Solution:
- Add missing includes.
- Change to `#elif defined(<value>)`.
Lenny Maiorani 4 years ago
parent
commit
7d8a9bdb1e
5 changed files with 10 additions and 3 deletions
  1. 5 0
      AK/Buffered.h
  2. 1 0
      AK/Optional.h
  3. 1 0
      AK/Singleton.h
  4. 2 2
      AK/SinglyLinkedListWithCount.h
  5. 1 1
      AK/StackInfo.cpp

+ 5 - 0
AK/Buffered.h

@@ -26,7 +26,12 @@
 
 #pragma once
 
+#include <AK/Noncopyable.h>
+#include <AK/Span.h>
+#include <AK/StdLibExtras.h>
 #include <AK/Stream.h>
+#include <AK/Types.h>
+#include <AK/kmalloc.h>
 
 namespace AK {
 

+ 1 - 0
AK/Optional.h

@@ -30,6 +30,7 @@
 #include <AK/Platform.h>
 #include <AK/StdLibExtras.h>
 #include <AK/Types.h>
+#include <AK/kmalloc.h>
 
 namespace AK {
 

+ 1 - 0
AK/Singleton.h

@@ -28,6 +28,7 @@
 
 #include <AK/Assertions.h>
 #include <AK/Atomic.h>
+#include <AK/Noncopyable.h>
 #include <AK/kmalloc.h>
 #ifdef KERNEL
 #    include <Kernel/Arch/i386/CPU.h>

+ 2 - 2
AK/SinglyLinkedListWithCount.h

@@ -96,12 +96,12 @@ public:
         return List::contains_slow(value);
     }
 
-    using Iterator = List::Iterator;
+    using Iterator = typename List::Iterator;
     friend Iterator;
     Iterator begin() { return List::begin(); }
     Iterator end() { return List::end(); }
 
-    using ConstIterator = List::ConstIterator;
+    using ConstIterator = typename List::ConstIterator;
     friend ConstIterator;
     ConstIterator begin() const { return List::begin(); }
     ConstIterator end() const { return List::end(); }

+ 1 - 1
AK/StackInfo.cpp

@@ -30,7 +30,7 @@
 
 #ifdef __serenity__
 #    include <serenity.h>
-#elif __linux__ or __APPLE__
+#elif defined(__linux__) or defined(__APPLE__)
 #    include <pthread.h>
 #endif