Pārlūkot izejas kodu

LibGfx+LibWeb: Propagate OOM when appending CanvasGradient color stops

MacDue 2 gadi atpakaļ
vecāks
revīzija
7bd78d40e9

+ 5 - 4
Userland/Libraries/LibGfx/PaintStyle.h

@@ -61,16 +61,17 @@ private:
 
 class GradientPaintStyle : public PaintStyle {
 public:
-    void add_color_stop(float position, Color color, Optional<float> transition_hint = {})
+    ErrorOr<void> add_color_stop(float position, Color color, Optional<float> transition_hint = {})
     {
-        add_color_stop(ColorStop { color, position, transition_hint });
+        return add_color_stop(ColorStop { color, position, transition_hint });
     }
 
-    void add_color_stop(ColorStop stop, bool sort = true)
+    ErrorOr<void> add_color_stop(ColorStop stop, bool sort = true)
     {
-        m_color_stops.append(stop);
+        TRY(m_color_stops.try_append(stop));
         if (sort)
             quick_sort(m_color_stops, [](auto& a, auto& b) { return a.position < b.position; });
+        return {};
     }
 
     void set_repeat_length(float repeat_length)

+ 1 - 1
Userland/Libraries/LibWeb/HTML/CanvasGradient.cpp

@@ -70,7 +70,7 @@ WebIDL::ExceptionOr<void> CanvasGradient::add_color_stop(double offset, Deprecat
         return WebIDL::SyntaxError::create(realm(), "Could not parse color for CanvasGradient");
 
     // 4. Place a new stop on the gradient, at offset offset relative to the whole gradient, and with the color parsed color.
-    m_gradient->add_color_stop(offset, parsed_color.value());
+    TRY_OR_THROW_OOM(realm().vm(), m_gradient->add_color_stop(offset, parsed_color.value()));
 
     // FIXME: If multiple stops are added at the same offset on a gradient, then they must be placed in the order added,
     //        with the first one closest to the start of the gradient, and each subsequent one infinitesimally further along