Browse Source

LibJS: Convert ProxyConstructor functions to ThrowCompletionOr

Idan Horowitz 3 years ago
parent
commit
7b5ccbc5ed

+ 3 - 3
Userland/Libraries/LibJS/Runtime/ProxyConstructor.cpp

@@ -34,7 +34,7 @@ void ProxyConstructor::initialize(GlobalObject& global_object)
     auto& vm = this->vm();
     NativeFunction::initialize(global_object);
     u8 attr = Attribute::Writable | Attribute::Configurable;
-    define_old_native_function(vm.names.revocable, revocable, 2, attr);
+    define_native_function(vm.names.revocable, revocable, 2, attr);
 
     define_direct_property(vm.names.length, Value(2), Attribute::Configurable);
 }
@@ -58,9 +58,9 @@ ThrowCompletionOr<Object*> ProxyConstructor::construct(FunctionObject&)
 }
 
 // 28.2.2.1 Proxy.revocable ( target, handler ), https://tc39.es/ecma262/#sec-proxy.revocable
-JS_DEFINE_OLD_NATIVE_FUNCTION(ProxyConstructor::revocable)
+JS_DEFINE_NATIVE_FUNCTION(ProxyConstructor::revocable)
 {
-    auto* proxy = TRY_OR_DISCARD(proxy_create(global_object, vm.argument(0), vm.argument(1)));
+    auto* proxy = TRY(proxy_create(global_object, vm.argument(0), vm.argument(1)));
 
     // 28.2.2.1.1 Proxy Revocation Functions, https://tc39.es/ecma262/#sec-proxy-revocation-functions
     auto* revoker = NativeFunction::create(global_object, "", [proxy_handle = make_handle(proxy)](auto&, auto&) -> ThrowCompletionOr<Value> {

+ 1 - 1
Userland/Libraries/LibJS/Runtime/ProxyConstructor.h

@@ -25,7 +25,7 @@ public:
 private:
     virtual bool has_constructor() const override { return true; }
 
-    JS_DECLARE_OLD_NATIVE_FUNCTION(revocable);
+    JS_DECLARE_NATIVE_FUNCTION(revocable);
 };
 
 }