0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

AK: Don't return null from String[View]::substring_view()

Browse source 
We expect the result to be usable with the
StringView::substring_view_starting_*_substring() methods.

See https://github.com/SerenityOS/serenity/pull/938
This commit is contained in:
Sergey Bugaev 2020-01-14 14:03:30 +03:00 • committed by Andreas Kling
parent b553a86048
commit 7ad9bfbc68
Notes: sideshowbarker 2024-07-19 10:04:06 +09:00
2 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/String.cpp
View file

@ -99,8 +99,6 @@ String String::substring(size_t start, size_t length) const
StringView String::substring_view(size_t start, size_t length) const StringView String::substring_view(size_t start, size_t length) const
{ {
if (!length)
return {};
ASSERT(m_impl); ASSERT(m_impl);
ASSERT(start + length <= m_impl->length()); ASSERT(start + length <= m_impl->length());
// FIXME: This needs some input bounds checking. // FIXME: This needs some input bounds checking.

2
AK/StringView.cpp
View file

@ -105,8 +105,6 @@ bool StringView::ends_with(const StringView& str) const
StringView StringView::substring_view(size_t start, size_t length) const StringView StringView::substring_view(size_t start, size_t length) const
{ {
if (!length)
return {};
ASSERT(start + length <= m_length); ASSERT(start + length <= m_length);
return { m_characters + start, length }; return { m_characters + start, length };
} }