0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibGUI/TreeView: Select parent on collapse

Browse source 
When collapsing a tree that contains the current selection, the parent
node becomes selected instead.
This commit is contained in:
Jelle Raaijmakers 2021-05-31 23:47:01 +02:00 • committed by Andreas Kling
parent 67a5e9f018
commit 7a4445a1fe
Notes: sideshowbarker 2024-07-18 17:05:47 +09:00
3 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibGUI/ModelIndex.cpp
View file

@ -19,6 +19,17 @@ Variant ModelIndex::data(ModelRole role) const
return model()->data(*this, role);
}
bool ModelIndex::is_parent_of(const ModelIndex& child) const
{
auto current_index = child.parent();
while (current_index.is_valid()) {
if (current_index == *this)
return true;
current_index = current_index.parent();
}
return false;
}
ModelIndex ModelIndex::sibling(int row, int column) const
{
if (!is_valid())

1
Userland/Libraries/LibGUI/ModelIndex.h
View file

@ -26,6 +26,7 @@ public:
void* internal_data() const { return m_internal_data; }
ModelIndex parent() const;
bool is_parent_of(const ModelIndex&) const;
bool operator==(const ModelIndex& other) const
{

4
Userland/Libraries/LibGUI/TreeView.cpp
View file

@ -148,6 +148,10 @@ void TreeView::toggle_index(const ModelIndex& index)
VERIFY(model()->row_count(index));
auto& metadata = ensure_metadata_for_index(index);
metadata.open = !metadata.open;
if (!metadata.open && index.is_parent_of(cursor_index()))
set_cursor(index, SelectionUpdate::Set);
if (on_toggle)
on_toggle(index, metadata.open);
update_column_sizes();