Prechádzať zdrojové kódy

LibHTML: Have TreeNode deref its children before deleting itself

This is definitely not the ideal ownership model here, but it's
something we'll have to iterate on as the engine grows.

At least this prevents us from leaking the entire world. :^)
Andreas Kling 5 rokov pred
rodič
commit
796e63b34c
1 zmenil súbory, kde vykonal 12 pridanie a 1 odobranie
  1. 12 1
      Libraries/LibHTML/TreeNode.h

+ 12 - 1
Libraries/LibHTML/TreeNode.h

@@ -15,8 +15,19 @@ public:
     void deref()
     {
         ASSERT(m_ref_count);
-        if (!--m_ref_count)
+        if (!--m_ref_count) {
+            if (m_next_sibling)
+                m_next_sibling->m_previous_sibling = m_previous_sibling;
+            if (m_previous_sibling)
+                m_previous_sibling->m_next_sibling = m_next_sibling;
+            T* next_child;
+            for (auto* child = m_first_child; child; child = next_child) {
+                next_child = child->m_next_sibling;
+                child->m_parent = nullptr;
+                child->deref();
+            }
             delete static_cast<T*>(this);
+        }
     }
     int ref_count() const { return m_ref_count; }