LibWasm: Turn memory read failures into traps

Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/7966168fea9
Pull-request: https://github.com/SerenityOS/serenity/pull/7395
Reviewed-by: https://github.com/linusg

Userland/Libraries/LibWasm/AbstractMachine/Interpreter.cpp

@@ -211,32 +211,35 @@ void Interpreter::call_address(Configuration& configuration, FunctionAddress add
     } while (false)
 
 template<typename T>
-static T read_value(ReadonlyBytes data)
+T Interpreter::read_value(ReadonlyBytes data)
 {
     T value;
     InputMemoryStream stream { data };
     auto ok = IsSigned<T> ? LEB128::read_signed(stream, value) : LEB128::read_unsigned(stream, value);
-    VERIFY(ok);
+    if (stream.handle_any_error() || !ok)
+        m_do_trap = true;
     return value;
 }
 
 template<>
-float read_value<float>(ReadonlyBytes data)
+float Interpreter::read_value<float>(ReadonlyBytes data)
 {
     InputMemoryStream stream { data };
     LittleEndian<u32> raw_value;
     stream >> raw_value;
-    VERIFY(!stream.has_any_error());
+    if (stream.handle_any_error())
+        m_do_trap = true;
     return bit_cast<float>(static_cast<u32>(raw_value));
 }
 
 template<>
-double read_value<double>(ReadonlyBytes data)
+double Interpreter::read_value<double>(ReadonlyBytes data)
 {
     InputMemoryStream stream { data };
     LittleEndian<u64> raw_value;
     stream >> raw_value;
-    VERIFY(!stream.has_any_error());
+    if (stream.handle_any_error())
+        m_do_trap = true;
     return bit_cast<double>(static_cast<u64>(raw_value));
 }
 

Userland/Libraries/LibWasm/AbstractMachine/Interpreter.h

@@ -27,6 +27,9 @@ private:
     template<typename V, typename T>
     MakeSigned<T> checked_signed_truncate(V);
 
+    template<typename T>
+    T read_value(ReadonlyBytes data);
+
     Vector<NonnullOwnPtr<Value>> pop_values(Configuration& configuration, size_t count);
     bool trap_if_not(bool value)
     {