0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibTimeZone: Include generated files before checked-in files

Browse source 
This is a rickety solution to a problem when using LibTimeZone as a
static archive, like we do for Android. When pulling symbols from an
archive into a shared library, lld will pick the weak symbols for our
timezone helpers and keep them. Even if there's a strong symbol in
another object file in the same archive, it ignores them. However,
if we make sure that the strong symbols for the generated files are
first in the list, then we avoid the problem altogether by relying
on linker specifics.
This commit is contained in:
Andrew Kaster 2023-09-17 13:20:04 -06:00 • committed by Andrew Kaster
parent de1bcf3597
commit 78c2fad89c
Notes: sideshowbarker 2024-07-17 03:14:39 +09:00
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibTimeZone/CMakeLists.txt
View file

@ -1,8 +1,8 @@
include(${SerenityOS_SOURCE_DIR}/Meta/CMake/time_zone_data.cmake)
set(SOURCES
TimeZone.cpp
${TIME_ZONE_DATA_SOURCES}
TimeZone.cpp
)
set(GENERATED_SOURCES ${CURRENT_LIB_GENERATED})