0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Meta: Make check-symbols.sh use the correct build directory

Browse source 
Since the build now happens in Build/$SERENITY_ARCH/ and not in Build/,
this updates check-symbols.sh to use the correct directory to check the
LibC symbols in. For some reason, the constant failures did not show
up as errors in CI.
This commit is contained in:
creator1creeper1 2022-01-14 13:26:23 +01:00 • committed by Linus Groh
parent c6a0365c58
commit 7851151cfb
Notes: sideshowbarker 2024-07-17 20:51:50 +09:00
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/cmake.yml vendored
View file

@ -180,6 +180,8 @@ jobs:
run: ccache -s
- name: Lint (Phase 2/2)
working-directory: ${{ github.workspace }}/Meta
env:
SERENITY_ARCH: ${{ matrix.arch }}
run: ./check-symbols.sh
- name: Create Serenity Rootfs

7
Meta/check-symbols.sh
View file

@ -9,12 +9,13 @@ cd "$script_path/.." || exit 1
# To eliminate the need for these symbols, avoid doing non-trivial construction of local statics in LibC.
FORBIDDEN_SYMBOLS="__cxa_guard_acquire __cxa_guard_release"
LIBC_PATH="Build/Userland/Libraries/LibC/libc.a"
TARGET="${SERENITY_ARCH:-"i686"}"
LIBC_PATH="Build/${TARGET}/Userland/Libraries/LibC/libc.a"
for forbidden_symbol in $FORBIDDEN_SYMBOLS; do
# check if there's an undefined reference to the symbol & it is not defined anywhere else in the library
nm $LIBC_PATH | grep "U $forbidden_symbol"
nm "$LIBC_PATH" | grep "U $forbidden_symbol"
APPEARS_AS_UNDEFINED=$?
nm $LIBC_PATH | grep "T $forbidden_symbol"
nm "$LIBC_PATH" | grep "T $forbidden_symbol"
APPEARS_AS_DEFINED=$?
if [ $APPEARS_AS_UNDEFINED -eq 0 ] && [ ! $APPEARS_AS_DEFINED -eq 0 ]; then
echo "Forbidden undefined symbol in LibC: $forbidden_symbol"