Pārlūkot izejas kodu

LibJS: Correctly return cached value for global var bindings

When the cached value was not an accessor, it was simply ignored.
This is the value we really want, so we can just return it.
Shows up to 5x improvements on some benchmarks,
and 1.4x in general js-benchmarks.
Hermes Junior 8 mēneši atpakaļ
vecāks
revīzija
77a46ab1b8
1 mainītis faili ar 1 papildinājumiem un 0 dzēšanām
  1. 1 0
      Libraries/LibJS/Bytecode/Interpreter.cpp

+ 1 - 0
Libraries/LibJS/Bytecode/Interpreter.cpp

@@ -1118,6 +1118,7 @@ inline ThrowCompletionOr<Value> get_global(Interpreter& interpreter, IdentifierT
             auto value = binding_object.get_direct(cache.property_offset.value());
             if (value.is_accessor())
                 return TRY(call(vm, value.as_accessor().getter(), js_undefined()));
+            return value;
         }
 
         // OPTIMIZATION: For global lexical bindings, if the global declarative environment hasn't changed,