We use cookies to ensure you get the best experience on our website
Начало Каталог Помощ
Регистрация Вход
0ct0pu5
/
ladybird
1
0
Разклонения 0
Файлове Задачи 0 Заявки за сливане 0 Уики
Преглед на файлове

LibWeb/CSS: Add support for `unicode-bidi` property

Khaled Lakehal преди 9 месеца
родител
16f2f6aa42
ревизия
77761e123d
променени са 10 файла, в които са добавени 75 реда и са изтрити 0 реда
Обединен изглед Покажи статистика за разликите
  1. 1 0
      Tests/LibWeb/Text/expected/css/getComputedStyle-print-all.txt
  2. 10 0
      Tests/LibWeb/Text/expected/css/unicode-bidi-computed-values.txt
  3. 29 0
      Tests/LibWeb/Text/input/css/unicode-bidi-computed-values.html
  4. 4 0
      Userland/Libraries/LibWeb/CSS/ComputedValues.h
  5. 8 0
      Userland/Libraries/LibWeb/CSS/Enums.json
  6. 5 0
      Userland/Libraries/LibWeb/CSS/Keywords.json
  7. 8 0
      Userland/Libraries/LibWeb/CSS/Properties.json
  8. 6 0
      Userland/Libraries/LibWeb/CSS/StyleProperties.cpp
  9. 1 0
      Userland/Libraries/LibWeb/CSS/StyleProperties.h
  10. 3 0
      Userland/Libraries/LibWeb/Layout/Node.cpp

+ 1 - 0
Tests/LibWeb/Text/expected/css/getComputedStyle-print-all.txt
Целия файл 

@@ -187,6 +187,7 @@ transition-delay: 0s
 
 transition-duration: 0s
 
 transition-duration: 0s
 
 transition-property: all
 
 transition-property: all
 
 transition-timing-function: ease
 
 transition-timing-function: ease
 
+unicode-bidi: normal
 
 user-select: auto
 
 user-select: auto
 
 vertical-align: baseline
 
 vertical-align: baseline
 
 width: 784px
 
 width: 784px

+ 10 - 0
Tests/LibWeb/Text/expected/css/unicode-bidi-computed-values.txt
Целия файл 

@@ -0,0 +1,10 @@
 
+normal
 
+embed
 
+isolate
 
+bidi-override
 
+isolate-override
 
+plaintext
 
+normal
 
+normal
 
+normal
 
+normal

+ 29 - 0
Tests/LibWeb/Text/input/css/unicode-bidi-computed-values.html
Целия файл 

@@ -0,0 +1,29 @@
 
+<!DOCTYPE html>
 
+<script src="../include.js"></script>
 
+
 
+<script>
 
+    test(() => {
 
+        const propertyName = "unicode-bidi";
 
+        const propertyValues = [
 
+            "normal",
 
+            "embed",
 
+            "isolate",
 
+            "bidi-override",
 
+            "isolate-override",
 
+            "plaintext",
 
+            "bad-value",
 
+            "bidi-override isolate-override",
 
+            "normal bad-value",
 
+            "bad-value normal",
 
+        ];
 
+
 
+        for (const propertyValue of propertyValues) {
 
+            const element = document.createElement("span");
 
+            element.style.setProperty(propertyName, propertyValue);
 
+            document.body.appendChild(element);
 
+            const computedValue = getComputedStyle(element).getPropertyValue(propertyName);
 
+            println(computedValue);
 
+            element.remove();
 
+        }
 
+    });
 
+</script>

+ 4 - 0
Userland/Libraries/LibWeb/CSS/ComputedValues.h
Целия файл 

@@ -183,6 +183,7 @@ public:
 
     static QuotesData quotes() { return QuotesData { .type = QuotesData::Type::Auto }; }
 
     static QuotesData quotes() { return QuotesData { .type = QuotesData::Type::Auto }; }
 
     static CSS::TransformBox transform_box() { return CSS::TransformBox::ViewBox; }
 
     static CSS::TransformBox transform_box() { return CSS::TransformBox::ViewBox; }
 
     static CSS::Direction direction() { return CSS::Direction::Ltr; }
 
     static CSS::Direction direction() { return CSS::Direction::Ltr; }
 
+    static CSS::UnicodeBidi unicode_bidi() { return CSS::UnicodeBidi::Normal; }
 
 
 
     // https://www.w3.org/TR/SVG/geometry.html
 
     // https://www.w3.org/TR/SVG/geometry.html
 
     static LengthPercentage cx() { return CSS::Length::make_px(0); }
 
     static LengthPercentage cx() { return CSS::Length::make_px(0); }
 
@@ -431,6 +432,7 @@ public:
 
     CSS::ObjectFit object_fit() const { return m_noninherited.object_fit; }
 
     CSS::ObjectFit object_fit() const { return m_noninherited.object_fit; }
 
     CSS::ObjectPosition object_position() const { return m_noninherited.object_position; }
 
     CSS::ObjectPosition object_position() const { return m_noninherited.object_position; }
 
     CSS::Direction direction() const { return m_inherited.direction; }
 
     CSS::Direction direction() const { return m_inherited.direction; }
 
+    CSS::UnicodeBidi unicode_bidi() const { return m_noninherited.unicode_bidi; }
 
 
 
     CSS::LengthBox const& inset() const { return m_noninherited.inset; }
 
     CSS::LengthBox const& inset() const { return m_noninherited.inset; }
 
     const CSS::LengthBox& margin() const { return m_noninherited.margin; }
 
     const CSS::LengthBox& margin() const { return m_noninherited.margin; }
 
@@ -647,6 +649,7 @@ protected:
 
         CSS::TableLayout table_layout { InitialValues::table_layout() };
 
         CSS::TableLayout table_layout { InitialValues::table_layout() };
 
         CSS::ObjectFit object_fit { InitialValues::object_fit() };
 
         CSS::ObjectFit object_fit { InitialValues::object_fit() };
 
         CSS::ObjectPosition object_position { InitialValues::object_position() };
 
         CSS::ObjectPosition object_position { InitialValues::object_position() };
 
+        CSS::UnicodeBidi unicode_bidi { InitialValues::unicode_bidi() };
 
 
 
         Optional<MaskReference> mask;
 
         Optional<MaskReference> mask;
 
         CSS::MaskType mask_type { InitialValues::mask_type() };
 
         CSS::MaskType mask_type { InitialValues::mask_type() };
 
@@ -782,6 +785,7 @@ public:
 
     void set_object_fit(CSS::ObjectFit value) { m_noninherited.object_fit = value; }
 
     void set_object_fit(CSS::ObjectFit value) { m_noninherited.object_fit = value; }
 
     void set_object_position(CSS::ObjectPosition value) { m_noninherited.object_position = value; }
 
     void set_object_position(CSS::ObjectPosition value) { m_noninherited.object_position = value; }
 
     void set_direction(CSS::Direction value) { m_inherited.direction = value; }
 
     void set_direction(CSS::Direction value) { m_inherited.direction = value; }
 
+    void set_unicode_bidi(CSS::UnicodeBidi value) { m_noninherited.unicode_bidi = value; }
 
 
 
     void set_fill(SVGPaint value) { m_inherited.fill = value; }
 
     void set_fill(SVGPaint value) { m_inherited.fill = value; }
 
     void set_stroke(SVGPaint value) { m_inherited.stroke = value; }
 
     void set_stroke(SVGPaint value) { m_inherited.stroke = value; }

+ 8 - 0
Userland/Libraries/LibWeb/CSS/Enums.json
Целия файл 

@@ -463,6 +463,14 @@
 
     "stroke-box",
 
     "stroke-box",
 
     "view-box "
 
     "view-box "
 
   ],
 
   ],
 
+  "unicode-bidi": [
 
+    "bidi-override",
 
+    "embed",
 
+    "isolate",
 
+    "isolate-override",
 
+    "normal",
 
+    "plaintext"
 
+  ],
 
   "vertical-align": [
 
   "vertical-align": [
 
     "baseline",
 
     "baseline",
 
     "bottom",
 
     "bottom",

+ 5 - 0
Userland/Libraries/LibWeb/CSS/Keywords.json
Целия файл 

@@ -79,6 +79,7 @@
 
   "background",
 
   "background",
 
   "backwards",
 
   "backwards",
 
   "baseline",
 
   "baseline",
 
+  "bidi-override",
 
   "blink",
 
   "blink",
 
   "block",
 
   "block",
 
   "bold",
 
   "bold",
 
@@ -142,6 +143,7 @@
 
   "ease-in-out",
 
   "ease-in-out",
 
   "ease-out",
 
   "ease-out",
 
   "ellipsis",
 
   "ellipsis",
 
+  "embed",
 
   "enabled",
 
   "enabled",
 
   "end",
 
   "end",
 
   "evenodd",
 
   "evenodd",
 
@@ -204,6 +206,8 @@
 
   "interlace",
 
   "interlace",
 
   "invert",
 
   "invert",
 
   "inverted",
 
   "inverted",
 
+  "isolate",
 
+  "isolate-override",
 
   "italic",
 
   "italic",
 
   "jump-both",
 
   "jump-both",
 
   "jump-end",
 
   "jump-end",
 
@@ -280,6 +284,7 @@
 
   "paged",
 
   "paged",
 
   "paused",
 
   "paused",
 
   "pixelated",
 
   "pixelated",
 
+  "plaintext",
 
   "pointer",
 
   "pointer",
 
   "portrait",
 
   "portrait",
 
   "pre",
 
   "pre",

+ 8 - 0
Userland/Libraries/LibWeb/CSS/Properties.json
Целия файл 

@@ -2678,6 +2678,14 @@
 
       "easing-function"
 
       "easing-function"
 
     ]
 
     ]
 
   },
 
   },
 
+  "unicode-bidi": {
 
+    "animation-type": "none",
 
+    "inherited": false,
 
+    "initial": "normal",
 
+    "valid-types": [
 
+      "unicode-bidi"
 
+    ]
 
+  },
 
   "user-select": {
 
   "user-select": {
 
     "affects-layout": false,
 
     "affects-layout": false,
 
     "animation-type": "discrete",
 
     "animation-type": "discrete",

+ 6 - 0
Userland/Libraries/LibWeb/CSS/StyleProperties.cpp
Целия файл 

@@ -1189,6 +1189,12 @@ Optional<CSS::Direction> StyleProperties::direction() const
 
     return keyword_to_direction(value->to_keyword());
 
     return keyword_to_direction(value->to_keyword());
 
 }
 
 }
 
 
 
+Optional<CSS::UnicodeBidi> StyleProperties::unicode_bidi() const
 
+{
 
+    auto value = property(CSS::PropertyID::UnicodeBidi);
 
+    return keyword_to_unicode_bidi(value->to_keyword());
 
+}
 
+
 
 Optional<CSS::MaskType> StyleProperties::mask_type() const
 
 Optional<CSS::MaskType> StyleProperties::mask_type() const
 
 {
 
 {
 
     auto value = property(CSS::PropertyID::MaskType);
 
     auto value = property(CSS::PropertyID::MaskType);

+ 1 - 0
Userland/Libraries/LibWeb/CSS/StyleProperties.h
Целия файл 

@@ -166,6 +166,7 @@ public:
 
     CSS::ObjectPosition object_position() const;
 
     CSS::ObjectPosition object_position() const;
 
     Optional<CSS::TableLayout> table_layout() const;
 
     Optional<CSS::TableLayout> table_layout() const;
 
     Optional<CSS::Direction> direction() const;
 
     Optional<CSS::Direction> direction() const;
 
+    Optional<CSS::UnicodeBidi> unicode_bidi() const;
 
 
 
     static Vector<CSS::Transformation> transformations_for_style_value(CSSStyleValue const& value);
 
     static Vector<CSS::Transformation> transformations_for_style_value(CSSStyleValue const& value);
 
     Vector<CSS::Transformation> transformations() const;
 
     Vector<CSS::Transformation> transformations() const;

+ 3 - 0
Userland/Libraries/LibWeb/Layout/Node.cpp
Целия файл 

@@ -896,6 +896,9 @@ void NodeWithStyle::apply_style(const CSS::StyleProperties& computed_style)
 
     if (auto direction = computed_style.direction(); direction.has_value())
 
     if (auto direction = computed_style.direction(); direction.has_value())
 
         computed_values.set_direction(direction.value());
 
         computed_values.set_direction(direction.value());
 
 
 
+    if (auto unicode_bidi = computed_style.unicode_bidi(); unicode_bidi.has_value())
 
+        computed_values.set_unicode_bidi(unicode_bidi.value());
 
+
 
     if (auto scrollbar_width = computed_style.scrollbar_width(); scrollbar_width.has_value())
 
     if (auto scrollbar_width = computed_style.scrollbar_width(); scrollbar_width.has_value())
 
         computed_values.set_scrollbar_width(scrollbar_width.value());
 
         computed_values.set_scrollbar_width(scrollbar_width.value());

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5