0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-03 21:10:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Fix incorrect behaviour in NamedNodeMap::removeNamedItem()

Browse source 
According to the spec we should return removed attribute, but the old
implementation returned nullptr instead.

Now we return the element's removed attribute.
This commit is contained in:
Alexander Narsudinov 2022-12-17 17:05:35 +03:00 committed by Andreas Kling
parent f2d7690702
commit 7679d38c5f
Notes: sideshowbarker 2024-07-18 00:41:35 +09:00 
Author: https://github.com/a-narsudinov
Commit: https://github.com/SerenityOS/serenity/commit/7679d38c5f
Pull-request: https://github.com/SerenityOS/serenity/pull/16549
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp
View file

@ -103,7 +103,7 @@ WebIDL::ExceptionOr<Attr const*> NamedNodeMap::remove_named_item(StringView qual
return WebIDL::NotFoundError::create(realm(), DeprecatedString::formatted("Attribute with name '{}' not found", qualified_name));
// 3. Return attr.
return nullptr;
return attribute;
}
// https://dom.spec.whatwg.org/#concept-element-attributes-get-by-name