LibWeb: Move the unique task source start to be last in Task::Source

This also adds some big text to draw attention to the fact that this enum value must remain last.
Author: https://github.com/Zaggy1024 Commit: https://github.com/SerenityOS/serenity/commit/766cd852d3 Pull-request: https://github.com/SerenityOS/serenity/pull/20837 Reviewed-by: https://github.com/trflynn89 ✅
2023-08-29 12:13:50 -05:00 · 2023-08-29 12:13:50 -05:00 · 766cd852d3 · 2024-07-18 00:41:35 +09:00
commit 766cd852d3
parent 40d732a73c
1 changed files with 5 additions and 4 deletions
--- a/Userland/Libraries/LibWeb/HTML/EventLoop/Task.h
+++ b/Userland/Libraries/LibWeb/HTML/EventLoop/Task.h
@ -44,12 +44,13 @@ public:
        // https://w3c.github.io/performance-timeline/#dfn-performance-timeline-task-source
        PerformanceTimeline,

-        // Some elements, such as the HTMLMediaElement, must have a unique task source per instance.
-        // Keep this field last, to serve as the base value of all unique task sources.
-        UniqueTaskSourceStart,
-
        // https://html.spec.whatwg.org/multipage/canvas.html#canvas-blob-serialisation-task-source
        CanvasBlobSerializationTask,
+
+        // !!! IMPORTANT: Keep this field last!
+        // This serves as the base value of all unique task sources.
+        // Some elements, such as the HTMLMediaElement, must have a unique task source per instance.
+        UniqueTaskSourceStart
    };

    static NonnullOwnPtr<Task> create(Source source, DOM::Document const* document, JS::SafeFunction<void()> steps)