0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibDebug: Allow DWARF compilation unit header version <= 4

Browse source 
I think this is okay, the main thing to protect against is new versions
of the format that we don't know about yet.

This happens because an .S file compiled into libc.so has version 2
instead of version 4 like everything else.

Fixes #4491.
This commit is contained in:
Andreas Kling 2020-12-23 00:50:22 +01:00
parent c77dda6827
commit 75da835ffb
Notes: sideshowbarker 2024-07-19 00:39:53 +09:00
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibDebug/Dwarf/DwarfInfo.cpp
View file

@ -60,7 +60,7 @@ void DwarfInfo::populate_compilation_units()
stream >> Bytes { &compilation_unit_header, sizeof(compilation_unit_header) };
ASSERT(compilation_unit_header.address_size == sizeof(u32));
ASSERT(compilation_unit_header.version == 4);
ASSERT(compilation_unit_header.version <= 4);
u32 length_after_header = compilation_unit_header.length - (sizeof(CompilationUnitHeader) - offsetof(CompilationUnitHeader, version));
m_compilation_units.empend(*this, unit_offset, compilation_unit_header);