Kernel: Disallow opening socket files

You can still open files that have sockets attached to them from inside the kernel via VFS::open() (and in fact, that is what LocalSocket itslef uses), but trying to do that from userspace using open() will now fail with ENXIO.
Author: https://github.com/bugaevc Commit: https://github.com/SerenityOS/serenity/commit/752617cbb20 Pull-request: https://github.com/SerenityOS/serenity/pull/2231
2020-05-15 12:05:44 +03:00 · 2020-05-15 12:05:44 +03:00 · 752617cbb2 · 2024-07-19 06:38:23 +09:00
commit 752617cbb2
parent 00c166e2ca
1 changed files with 4 additions and 0 deletions
--- a/Kernel/Process.cpp
+++ b/Kernel/Process.cpp
@ -2082,6 +2082,10 @@ int Process::sys$open(const Syscall::SC_open_params* user_params)
    if (result.is_error())
        return result.error();
    auto description = result.value();
+
+    if (description->inode() && description->inode()->socket())
+        return -ENXIO;
+
    u32 fd_flags = (options & O_CLOEXEC) ? FD_CLOEXEC : 0;
    m_fds[fd].set(move(description), fd_flags);
    return fd;