0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 21:40:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Implement Temporal.PlainDate.prototype.toLocaleString()

Browse source
This commit is contained in:
Linus Groh 2021-08-19 00:23:48 +01:00
parent 402f04c2fc
commit 73d888e9e6
Notes: sideshowbarker 2024-07-18 05:29:48 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/73d888e9e6a
3 changed files with 42 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibJS/Runtime/Temporal/PlainDatePrototype.cpp
View file

@ -52,6 +52,7 @@ void PlainDatePrototype::initialize(GlobalObject& global_object)
define_native_function(vm.names.withCalendar, with_calendar, 1, attr);
define_native_function(vm.names.equals, equals, 1, attr);
define_native_function(vm.names.toString, to_string, 0, attr);
define_native_function(vm.names.toLocaleString, to_locale_string, 0, attr);
define_native_function(vm.names.valueOf, value_of, 0, attr);
}
@ -425,6 +426,23 @@ JS_DEFINE_NATIVE_FUNCTION(PlainDatePrototype::to_string)
return js_string(vm, *string);
}
// 3.3.29 Temporal.PlainDate.prototype.toLocaleString ( [ locales [ , options ] ] ), https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.tolocalestring
JS_DEFINE_NATIVE_FUNCTION(PlainDatePrototype::to_locale_string)
{
// 1. Let temporalDate be the this value.
// 2. Perform ? RequireInternalSlot(temporalDate, [[InitializedTemporalDate]]).
auto* temporal_date = typed_this(global_object);
if (vm.exception())
return {};
// 3. Return ? TemporalDateToString(temporalDate, "auto").
auto string = temporal_date_to_string(global_object, *temporal_date, "auto"sv);
if (vm.exception())
return {};
return js_string(vm, *string);
}
// 3.3.31 Temporal.PlainDate.prototype.valueOf ( ), https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.valueof
JS_DEFINE_NATIVE_FUNCTION(PlainDatePrototype::value_of)
{

1
Userland/Libraries/LibJS/Runtime/Temporal/PlainDatePrototype.h
View file

@ -38,6 +38,7 @@ private:
JS_DECLARE_NATIVE_FUNCTION(with_calendar);
JS_DECLARE_NATIVE_FUNCTION(equals);
JS_DECLARE_NATIVE_FUNCTION(to_string);
JS_DECLARE_NATIVE_FUNCTION(to_locale_string);
JS_DECLARE_NATIVE_FUNCTION(value_of);
};

23
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.prototype.toLocaleString.js Normal file
View file

@ -0,0 +1,23 @@
describe("correct behavior", () => {
test("length is 0", () => {
expect(Temporal.PlainDate.prototype.toLocaleString).toHaveLength(0);
});
test("basic functionality", () => {
let plainDate;
plainDate = new Temporal.PlainDate(2021, 7, 6);
expect(plainDate.toLocaleString()).toBe("2021-07-06");
plainDate = new Temporal.PlainDate(2021, 7, 6, { toString: () => "foo" });
expect(plainDate.toLocaleString()).toBe("2021-07-06[u-ca=foo]");
});
});
describe("errors", () => {
test("this value must be a Temporal.PlainDate object", () => {
expect(() => {
Temporal.PlainDate.prototype.toLocaleString.call("foo");
}).toThrowWithMessage(TypeError, "Not a Temporal.PlainDate");
});
});