Kernel: Fix BlockCondition::unblock return value

BlockCondition::unblock should return true if it unblocked at least one thread, not if iterating the blockers had been stopped. This is a regression introduced by 49a76164c. Fixes #4670
Author: https://github.com/tomuta Commit: https://github.com/SerenityOS/serenity/commit/72440d90fea Pull-request: https://github.com/SerenityOS/serenity/pull/4680 Issue: https://github.com/SerenityOS/serenity/issues/4670
2020-12-30 19:29:41 -07:00 · 2020-12-30 19:29:41 -07:00 · 72440d90fe · 2024-07-19 00:19:14 +09:00
commit 72440d90fe
parent 82c4812730
1 changed files with 3 additions and 1 deletions
--- a/Kernel/Thread.h
+++ b/Kernel/Thread.h
@ -409,16 +409,18 @@ public:
        {
            ASSERT(m_lock.is_locked());
            bool stop_iterating = false;
+            bool did_unblock = false;
            for (size_t i = 0; i < m_blockers.size() && !stop_iterating;) {
                auto& info = m_blockers[i];
                if (unblock_one(*info.blocker, info.data, stop_iterating)) {
                    m_blockers.remove(i);
+                    did_unblock = true;
                    continue;
                }

                i++;
            }
-            return !stop_iterating;
+            return did_unblock;
        }

        virtual bool should_add_blocker(Blocker&, void*) { return true; }